Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Unified Diff: pkg/compiler/lib/src/resolution/members.dart

Issue 2473743002: Changed warning to hint for `x as T` where T is a method type variable. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/resolution/members.dart
diff --git a/pkg/compiler/lib/src/resolution/members.dart b/pkg/compiler/lib/src/resolution/members.dart
index c009b7a6fefa6a02c3bdcc38e246a253ccc9d55b..00b3725fa85c71a57e56f54c2441f176cfd19779 100644
--- a/pkg/compiler/lib/src/resolution/members.dart
+++ b/pkg/compiler/lib/src/resolution/members.dart
@@ -1142,10 +1142,10 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
DartType type =
resolveTypeAnnotation(typeNode, registerCheckedModeCheck: false);
- // GENERIC_METHODS: Method type variables are not reified so we must warn
- // about the error which will occur at runtime.
+ // GENERIC_METHODS: Method type variables are not reified, so we must inform
+ // the developer about the potentially bug-inducing semantics.
if (type is MethodTypeVariableType) {
- reporter.reportWarningMessage(
+ reporter.reportHintMessage(
node, MessageKind.TYPE_VARIABLE_FROM_METHOD_CONSIDERED_DYNAMIC);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698