Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 247373002: CallICStub with a "never patch" approach until customization. (Closed)

Created:
6 years, 8 months ago by mvstanton
Modified:
6 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

CallICStub with a "never patch" approach by default. Patching will occur only when custom feedback needs to be gathered (future CLs). Now rebased on https://codereview.chromium.org/254623002/, which moves the type feedback vector to the SharedFunctionInfo. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21093

Patch Set 1 #

Patch Set 2 : Ports and rebase #

Patch Set 3 : IA32 new version, ports required. #

Patch Set 4 : Adapt to feedback vector in SharedFunctionInfo. #

Patch Set 5 : LiveEdit special handling. #

Patch Set 6 : No patch on mega, visit runtime on mono. #

Patch Set 7 : Ports. #

Total comments: 1

Patch Set 8 : REBASE + code size multiplier. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1179 lines, -658 lines) Patch
M src/arm/builtins-arm.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 3 4 5 6 7 4 chunks +164 lines, -63 lines 0 comments Download
M src/arm/debug-arm.cc View 1 2 3 4 5 6 7 3 chunks +10 lines, -20 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 2 3 4 5 6 7 9 chunks +26 lines, -62 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 4 5 6 7 5 chunks +176 lines, -62 lines 0 comments Download
M src/arm64/debug-arm64.cc View 1 2 3 4 5 6 7 3 chunks +10 lines, -20 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 3 4 5 6 7 9 chunks +25 lines, -63 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/ast.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/builtins.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins.cc View 1 2 3 4 5 6 7 2 chunks +5 lines, -6 lines 0 comments Download
M src/code-stubs.h View 1 2 3 4 5 6 7 7 chunks +46 lines, -15 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 4 5 6 7 2 chunks +5 lines, -1 line 0 comments Download
M src/debug.h View 1 2 3 4 5 6 7 3 chunks +1 line, -4 lines 0 comments Download
M src/debug.cc View 1 2 3 4 5 6 7 7 chunks +18 lines, -11 lines 0 comments Download
M src/factory.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -2 lines 0 comments Download
M src/full-codegen.h View 1 2 3 4 5 6 7 2 chunks +8 lines, -8 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 4 5 6 7 5 chunks +173 lines, -62 lines 0 comments Download
M src/ia32/debug-ia32.cc View 1 2 3 4 5 6 7 3 chunks +11 lines, -21 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 3 4 5 6 7 10 chunks +27 lines, -65 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/ic.h View 1 2 3 4 5 6 7 3 chunks +77 lines, -0 lines 0 comments Download
M src/ic.cc View 1 2 3 4 5 6 7 7 chunks +91 lines, -3 lines 0 comments Download
M src/liveedit.h View 1 2 3 4 5 6 7 4 chunks +9 lines, -1 line 0 comments Download
M src/liveedit.cc View 1 2 3 4 5 6 7 5 chunks +27 lines, -0 lines 0 comments Download
M src/log.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M src/log.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 2 3 4 5 6 7 3 chunks +3 lines, -1 line 0 comments Download
M src/objects-visiting-inl.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M src/spaces.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -1 line 0 comments Download
M src/v8globals.h View 1 2 3 4 5 6 7 2 chunks +7 lines, -2 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 5 6 7 4 chunks +187 lines, -69 lines 0 comments Download
M src/x64/debug-x64.cc View 1 2 3 4 5 6 7 3 chunks +10 lines, -21 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 3 4 5 6 7 9 chunks +27 lines, -64 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-liveedit-newsource.js View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Toon, Here is the revised CallICStub. It's rebased on a CL that needs to ...
6 years, 8 months ago (2014-04-25 12:37:33 UTC) #1
Toon Verwaest
lgtm https://codereview.chromium.org/247373002/diff/130001/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): https://codereview.chromium.org/247373002/diff/130001/src/ia32/code-stubs-ia32.cc#newcode2465 src/ia32/code-stubs-ia32.cc:2465: // (non_function is bound in EmitSlowCase) Drop () ...
6 years, 7 months ago (2014-04-29 15:20:30 UTC) #2
mvstanton
6 years, 7 months ago (2014-04-30 14:34:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #8 manually as r21093 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698