scripts/slave/recipe_modules/v8/chromium_config.py - Issue 24737002: Add Paths as first-class types in configs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/v8/chromium_config.py

Issue 24737002: Add Paths as first-class types in configs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: license Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/v8/chromium_config.py

diff --git a/scripts/slave/recipe_modules/v8/chromium_config.py b/scripts/slave/recipe_modules/v8/chromium_config.py

index 6d93d8d2b5c038d2fd55213b5f2475cc110248ec..f7d48e097d956be7ee3e856ae3bc59d4abe5e8da 100644

--- a/scripts/slave/recipe_modules/v8/chromium_config.py

+++ b/scripts/slave/recipe_modules/v8/chromium_config.py

@@ -1,3 +1,4 @@

+from slave.recipe_config_types import Path

from RECIPE_MODULES.chromium import CONFIG_CTX

@@ -14,7 +15,7 @@ def v8(c):

c.gyp_env.GYP_DEFINES['v8_target_arch'] = v8_target_arch

del c.gyp_env.GYP_DEFINES['component']

c.build_config_fs = c.BUILD_CONFIG

- c.build_dir = ''

+ c.build_dir = Path('[CHECKOUT]')

c.compile_py.build_tool = 'make'

c.compile_py.default_targets = ['buildbot']