Add Paths as first-class types in configs.

scripts/slave/recipe_modules/android/config.py

Index: scripts/slave/recipe_modules/android/config.py
diff --git a/scripts/slave/recipe_modules/android/config.py b/scripts/slave/recipe_modules/android/config.py
index 711f464869a2b7ee2d7a25c5c1f8da5b96ce1d65..9785ed95b5049f4459b0be62d1883c8c7a51762d 100644
--- a/scripts/slave/recipe_modules/android/config.py
+++ b/scripts/slave/recipe_modules/android/config.py
@@ -5,7 +5,12 @@
 from slave.recipe_config import config_item_context, ConfigGroup, Single, List
 from slave.recipe_config import Static
 
+from slave.recipe_config_types import Path

[agable, 2013/09/26 21:46:02]

No empty line above this.

[iannucci, 2013/09/27 02:08:20]

Done.

+
 def BaseConfig(USE_MIRROR=False):
+  chromium_in_android_subpath = ('external', 'chromium_org')
+  build_path = Path('slave_build', 'android-src')
+
   return ConfigGroup(
     lunch_flavor = Single(basestring),
     repo = ConfigGroup(
@@ -14,6 +19,13 @@ def BaseConfig(USE_MIRROR=False):
       sync_flags = List(basestring),
     ),
     USE_MIRROR = Static(bool(USE_MIRROR)),
+
+    # Path stuff
+    chromium_in_android_subpath = Static('/'.join(chromium_in_android_subpath)),

[agable, 2013/09/26 21:46:02]

This is super weird and makes me a little uncomfortable. Not entirely sure why
-- or what else there is to do about it since they explicitly require a subpath
-- but it's weird nonetheless. I'll think about it some more.

[iannucci, 2013/09/27 02:08:20]

Yeah that was pretty much my reaction. I decided to punt for now.

+    build_path = Static(build_path),
+    slave_chromium_in_android_path = Static(
+      build_path(*chromium_in_android_subpath)),
+    slave_android_out_path = Static(build_path('out')),
   )
 
 config_ctx = config_item_context(