scripts/slave/recipe_modules/v8/chromium_config.py - Issue 24737002: Add Paths as first-class types in configs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipe_modules/v8/chromium_config.py

Issue 24737002: Add Paths as first-class types in configs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	1 from slave.recipe_config_types import Path

1 from RECIPE_MODULES.chromium import CONFIG_CTX	2 from RECIPE_MODULES.chromium import CONFIG_CTX

2	3

3	4

4 @CONFIG_CTX()	5 @CONFIG_CTX()

5 def v8(c):	6 def v8(c):

6 if c.TARGET_ARCH == 'arm':	7 if c.TARGET_ARCH == 'arm':

7 v8_target_arch = 'arm'	8 v8_target_arch = 'arm'

8 elif c.TARGET_ARCH == 'mips':	9 elif c.TARGET_ARCH == 'mips':

9 v8_target_arch = 'mips'	10 v8_target_arch = 'mips'

10 elif c.TARGET_BITS == 64:	11 elif c.TARGET_BITS == 64:

11 v8_target_arch = 'x64'	12 v8_target_arch = 'x64'

12 else:	13 else:

13 v8_target_arch = 'ia32'	14 v8_target_arch = 'ia32'

14 c.gyp_env.GYP_DEFINES['v8_target_arch'] = v8_target_arch	15 c.gyp_env.GYP_DEFINES['v8_target_arch'] = v8_target_arch

15 del c.gyp_env.GYP_DEFINES['component']	16 del c.gyp_env.GYP_DEFINES['component']

16 c.build_config_fs = c.BUILD_CONFIG	17 c.build_config_fs = c.BUILD_CONFIG

17 c.build_dir = ''	18 c.build_dir = Path('checkout')

18	19

19 c.compile_py.build_tool = 'make'	20 c.compile_py.build_tool = 'make'

20 c.compile_py.default_targets = ['buildbot']	21 c.compile_py.default_targets = ['buildbot']

OLD	NEW