Add Paths as first-class types in configs.

scripts/slave/recipe_modules/path/config.py

+
+from slave.recipe_config import config_item_context, ConfigGroup, Dict, Static
+
+from slave.recipe_config_types import Path

[agable, 2013/09/26 21:46:02]

No empty line above this.

[iannucci, 2013/09/27 02:08:20]

Done.

+
+def BaseConfig(CURRENT_WORKING_DIR, **_kwargs):
+  assert CURRENT_WORKING_DIR[0].endswith(('\\', '/'))
+  return ConfigGroup(
+    # base path name -> [tokenized absolute path]
+    base_paths    = Dict(value_type=tuple),
+
+    # dynamic path name -> Path object (referencing one of the base_paths)
+    dynamic_paths = Dict(value_type=(Path, type(None))),
+
+    CURRENT_WORKING_DIR = Static(tuple(CURRENT_WORKING_DIR)),
+  )
+
+VAR_TEST_MAP = {
+  'CURRENT_WORKING_DIR': (
+    ['/', 'b', 'build', 'slave', 'fake_slave', 'build'],
+    ['D:\\', 'build', 'slave', 'fake_slave', 'build'],

[agable, 2013/09/26 21:46:02]

It's generally E:\\b\build...

[iannucci, 2013/09/27 02:08:20]

Done.

[agable, 2013/09/27 17:48:16]

You're still missing the \b\ part of the path.

+  ),
+}
+
+def test_name(args):
+  if args['CURRENT_WORKING_DIR'][0] == '/':
+    return 'posix'
+  else:
+    return 'windows'
+
+config_ctx = config_item_context(BaseConfig, VAR_TEST_MAP, test_name)
+
+@config_ctx(is_root=True)
+def BASE(c):
+  c.base_paths['cwd'] = c.CURRENT_WORKING_DIR
+
+@config_ctx()
+def buildbot(c):
+  c.base_paths['root'] = c.CURRENT_WORKING_DIR[:-4]

[agable, 2013/09/26 21:46:02]

Magic number! Comment it.

[iannucci, 2013/09/27 02:08:20]

This IS the comment... the root path is 4 levels up from the CWD. You really
want a comment saying that?

+  c.base_paths['slave_build'] = c.CURRENT_WORKING_DIR
+  for token in ('build_internal', 'build', 'depot_tools'):
+    c.base_paths[token] = c.base_paths['root'] + (token,)
+  c.dynamic_paths['checkout'] = None
+