Add Paths as first-class types in configs.

scripts/slave/recipe_modules/gclient/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from slave import recipe_api
 
 def jsonish_to_python(spec, is_top=False):
   ret = ''
   if is_top:  # We're the 'top' level, so treat this dict as a suite.
     ret = '\n'.join(
@@ skipping 128 matching lines @@
 
       cfg_cmds = [
         ('user.name', 'local_bot'),
         ('user.email', 'local_bot@example.com'),
       ]
       for var, val in cfg_cmds:
         name = 'recurse (git config %s)' % var
         steps.append(self(name, ['recurse', 'git', 'config', var, val],
                           **kwargs))
 
-    cwd = kwargs.get('cwd')
-    for c in cfg.checkouts:
-      path = self.m.path.slave_build(c)
-      if cwd:
-        path = self.m.path.join(cwd, c)
-      self.m.path.add_checkout(path)
-    for s in cfg.solutions:
-      path = self.m.path.slave_build(s.name)
-      if cwd:
-        path = self.m.path.join(cwd, s.name)
-      self.m.path.add_checkout(path)
+    cwd = kwargs.get('cwd', self.m.path.slave_build)
+    self.m.path.set_dynamic_path(
+      'checkout', cwd(*cfg.solutions[0].name.split(self.m.path.sep)),

[agable, 2013/09/26 21:46:02]

So we've lost the ability to save multiple paths into path.checkout and then
select one later. I guess this is mitigated by the json output from gclient
being in step_history, but double check it hasn't negatively affected anyone.

[iannucci, 2013/09/27 02:08:20]

I converted the users of this feature over. It was dumb anyway, since in order
to select the checkout, you needed to know what the path to it was.

+      default=True)
 
     return steps
 
   def revert(self, **kwargs):
     """Return a gclient_safe_revert step."""
     # Not directly calling gclient, so don't use self().
     prefix = 'gclient '
     if self.spec_alias:
       prefix = ('[spec: %s] ' % self.spec_alias) + prefix
 
     return self.m.python(prefix + 'revert',
         self.m.path.build('scripts', 'slave', 'gclient_safe_revert.py'),
         ['.', self.m.path.depot_tools('gclient', wrapper=True)],
         **kwargs
     )
 
   def runhooks(self, args=None, **kwargs):
     """Return a 'gclient runhooks' step."""
     args = args or []
     assert isinstance(args, (list, tuple))
     return self('runhooks', ['runhooks'] + list(args), **kwargs)