Add Paths as first-class types in configs.

scripts/slave/recipe_api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import functools
 
 from .recipe_test_api import DisabledTestData, ModuleTestData, StepTestData
 
 from .recipe_util import ModuleInjectionSite
 
@@ skipping 26 matching lines @@
   def get_config_defaults(self):  # pylint: disable=R0201
     """
     Allows your api to dynamically determine static default values for configs.
     """
     return {}
 
   def make_config(self, config_name=None, optional=False, **CONFIG_VARS):
     """Returns a 'config blob' for the current API."""
     return self.make_config_params(config_name, optional, **CONFIG_VARS)[0]
 
-  def make_config_params(self, config_name=None, optional=False, **CONFIG_VARS):
+  def make_config_params(self, config_name, optional=False, **CONFIG_VARS):

[agable, 2013/09/26 21:46:02]

Why did these lose their default value of config_name=None? They both still
special-case the value of None.

[iannucci, 2013/09/27 02:08:20]

Because it's mostly called from make_config and set_config, I figured having
this be explicit (now that make_config and set_config both symmetrically allow
this to be None).

     """Returns a 'config blob' for the current API, and the computed params
     for all dependent configurations.
 
     The params have the following order of precendence. Each subsequent param
     is dict.update'd into the final parameters, so the order is from lowest to
     higest precedence on a per-key basis:
       * if config_name in CONFIG_CTX
         * get_config_defaults()
         * CONFIG_CTX[config_name].DEFAULT_CONFIG_VARS()
         * CONFIG_VARS
@@ skipping 20 matching lines @@
       if config_name is None:
         return base, params
       else:
         return itm(base), params
     except KeyError:
       if optional:
         return None, generic_params
       else:
         raise  # TODO(iannucci): raise a better exception.
 
-  def set_config(self, config_name, optional=False, **CONFIG_VARS):
+  def set_config(self, config_name=None, optional=False, include_deps=True,
+                 **CONFIG_VARS):
     """Sets the modules and its dependencies to the named configuration."""
     assert self._module
     config, params = self.make_config_params(config_name, optional,
                                              **CONFIG_VARS)
     if config:
       self.c = config
-    # TODO(iannucci): This is 'inefficient', since if a dep comes up multiple
-    # times in this recursion, it will get set_config()'d multiple times
-    for dep in self._module.DEPS:
-      getattr(self.m, dep).set_config(config_name, optional=True, **params)
+
+    if include_deps:
+      # TODO(iannucci): This is 'inefficient', since if a dep comes up multiple
+      # times in this recursion, it will get set_config()'d multiple times
+      for dep in self._module.DEPS:
+        getattr(self.m, dep).set_config(config_name, optional=True, **params)
 
   def apply_config(self, config_name, config_object=None):
     """Apply a named configuration to the provided config object or self."""
     self._module.CONFIG_CTX.CONFIG_ITEMS[config_name](config_object or self.c)
 
   @property
   def name(self):
     return self._module.NAME
 
 
@@ skipping 24 matching lines @@
         % {
           'meth': func.__name__,
           'mod': self._module,  # pylint: disable=W0212
         })
       assert 'default_step_data' not in ret
       data = test_fn(*args, **kwargs)
       assert isinstance(data, StepTestData)
       ret['default_step_data'] = data
     return ret
   return inner