test/unittests/compiler/tail-call-optimization-unittest.cc - Issue 2473643002: Revert of [turbofan] Support variable size argument popping in TF-generated functions

Unified Diff: test/unittests/compiler/tail-call-optimization-unittest.cc

Issue 2473643002: Revert of [turbofan] Support variable size argument popping in TF-generated functions (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Index: test/unittests/compiler/tail-call-optimization-unittest.cc

diff --git a/test/unittests/compiler/tail-call-optimization-unittest.cc b/test/unittests/compiler/tail-call-optimization-unittest.cc

index 127f269960c528557aa1ca6fa902ac2ae5ce168e..56fedeeb0903af9af4bcc2f005af221aac5631c9 100644

--- a/test/unittests/compiler/tail-call-optimization-unittest.cc

+++ b/test/unittests/compiler/tail-call-optimization-unittest.cc

@@ -39,9 +39,7 @@

Node* call = graph()->NewNode(common()->Call(kCallDescriptor), p0, p1,

graph()->start(), graph()->start());

Node* if_success = graph()->NewNode(common()->IfSuccess(), call);

- Node* zero = graph()->NewNode(common()->Int32Constant(0));

- Node* ret =

- graph()->NewNode(common()->Return(), zero, call, call, if_success);

+ Node* ret = graph()->NewNode(common()->Return(), call, call, if_success);

Reduction r = Reduce(ret);

ASSERT_FALSE(r.Changed());

}

@@ -62,9 +60,7 @@

graph()->start(), graph()->start());

Node* if_success = graph()->NewNode(common()->IfSuccess(), call);

Node* if_exception = graph()->NewNode(common()->IfException(), call, call);

- Node* zero = graph()->NewNode(common()->Int32Constant(0));

- Node* ret =

- graph()->NewNode(common()->Return(), zero, call, call, if_success);

+ Node* ret = graph()->NewNode(common()->Return(), call, call, if_success);

Node* end = graph()->NewNode(common()->End(1), if_exception);

graph()->SetEnd(end);

Reduction r = Reduce(ret);

@@ -86,9 +82,7 @@

Node* call = graph()->NewNode(common()->Call(kCallDescriptor), p0, p1,

graph()->start(), graph()->start());

Node* if_success = graph()->NewNode(common()->IfSuccess(), call);

- Node* zero = graph()->NewNode(common()->Int32Constant(0));

- Node* ret =

- graph()->NewNode(common()->Return(), zero, call, call, if_success);

+ Node* ret = graph()->NewNode(common()->Return(), call, call, if_success);

Reduction r = Reduce(ret);

ASSERT_TRUE(r.Changed());

EXPECT_THAT(r.replacement(), IsTailCall(kCallDescriptor, p0, p1,

@@ -110,9 +104,7 @@

Node* call = graph()->NewNode(common()->Call(kCallDescriptor), p0, p1,

graph()->start(), graph()->start());

Node* if_success = graph()->NewNode(common()->IfSuccess(), call);

- Node* zero = graph()->NewNode(common()->Int32Constant(0));

- Node* ret =

- graph()->NewNode(common()->Return(), zero, call, call, if_success);

+ Node* ret = graph()->NewNode(common()->Return(), call, call, if_success);

Reduction r = Reduce(ret);

ASSERT_FALSE(r.Changed());

}

@@ -133,9 +125,7 @@

graph()->start(), graph()->start());

Node* if_success = graph()->NewNode(common()->IfSuccess(), call);

Node* if_exception = graph()->NewNode(common()->IfException(), call, call);

- Node* zero = graph()->NewNode(common()->Int32Constant(0));

- Node* ret =

- graph()->NewNode(common()->Return(), zero, call, call, if_success);

+ Node* ret = graph()->NewNode(common()->Return(), call, call, if_success);

Node* end = graph()->NewNode(common()->End(1), if_exception);

graph()->SetEnd(end);

Reduction r = Reduce(ret);

@@ -156,9 +146,7 @@

Node* call = graph()->NewNode(common()->Call(kCallDescriptor), p0, p1,

graph()->start(), graph()->start());

Node* if_success = graph()->NewNode(common()->IfSuccess(), call);

- Node* zero = graph()->NewNode(common()->Int32Constant(0));

- Node* ret =

- graph()->NewNode(common()->Return(), zero, call, call, if_success);

+ Node* ret = graph()->NewNode(common()->Return(), call, call, if_success);

Reduction r = Reduce(ret);

ASSERT_TRUE(r.Changed());

EXPECT_THAT(r.replacement(), IsTailCall(kCallDescriptor, p0, p1,

« no previous file with comments | « test/unittests/compiler/scheduler-unittest.cc ('k') | no next file » | no next file with comments »