Revert of [turbofan] Support variable size argument popping in TF-generated functions

test/unittests/compiler/effect-control-linearizer-unittest.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/effect-control-linearizer.h"
 #include "src/compiler/access-builder.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/linkage.h"
 #include "src/compiler/node-properties.h"
 #include "src/compiler/schedule.h"
@@ skipping 42 matching lines @@
 }  // namespace
 
 TEST_F(EffectControlLinearizerTest, SimpleLoad) {
   Schedule schedule(zone());
 
   // Create the graph.
   Node* heap_number = NumberConstant(0.5);
   Node* load = graph()->NewNode(
       simplified()->LoadField(AccessBuilder::ForHeapNumberValue()), heap_number,
       graph()->start(), graph()->start());
-  Node* zero = graph()->NewNode(common()->Int32Constant(0));
-  Node* ret = graph()->NewNode(common()->Return(), zero, load, graph()->start(),
+  Node* ret = graph()->NewNode(common()->Return(), load, graph()->start(),
                                graph()->start());
 
   // Build the basic block structure.
   BasicBlock* start = schedule.start();
   schedule.rpo_order()->push_back(start);
   start->set_rpo_number(0);
 
   // Populate the basic blocks with nodes.
   schedule.AddNode(start, graph()->start());
   schedule.AddNode(start, heap_number);
@@ skipping 24 matching lines @@
       simplified()->LoadField(AccessBuilder::ForHeapNumberValue()), heap_number,
       graph()->start(), if_true);
 
   Node* if_false = graph()->NewNode(common()->IfFalse(), branch);
   Node* vfalse = Float64Constant(2);
 
   Node* merge = graph()->NewNode(common()->Merge(2), if_true, if_false);
   Node* phi = graph()->NewNode(
       common()->Phi(MachineRepresentation::kFloat64, 2), vtrue, vfalse, merge);
 
-  Node* zero = graph()->NewNode(common()->Int32Constant(0));
   Node* ret =
-      graph()->NewNode(common()->Return(), zero, phi, graph()->start(), merge);
+      graph()->NewNode(common()->Return(), phi, graph()->start(), merge);
 
   // Build the basic block structure.
   BasicBlock* start = schedule.start();
   schedule.rpo_order()->push_back(start);
   start->set_rpo_number(0);
 
   BasicBlock* tblock = AddBlockToSchedule(&schedule);
   BasicBlock* fblock = AddBlockToSchedule(&schedule);
   BasicBlock* mblock = AddBlockToSchedule(&schedule);
 
@@ skipping 79 matching lines @@
   Node* if_false1 = graph()->NewNode(common()->IfFalse(), branch1);
   Node* merge1 = graph()->NewNode(common()->Merge(2), if_true1, if_false1);
 
   // Second floating diamond.
   Node* branch2 =
       graph()->NewNode(common()->Branch(), const0, graph()->start());
   Node* if_true2 = graph()->NewNode(common()->IfTrue(), branch2);
   Node* if_false2 = graph()->NewNode(common()->IfFalse(), branch2);
   Node* merge2 = graph()->NewNode(common()->Merge(2), if_true2, if_false2);
 
-  Node* zero = graph()->NewNode(common()->Int32Constant(0));
-  Node* ret = graph()->NewNode(common()->Return(), zero, call, graph()->start(),
-                               if_success);
+  Node* ret =
+      graph()->NewNode(common()->Return(), call, graph()->start(), if_success);
 
   // Build the basic block structure.
   BasicBlock* start = schedule.start();
   schedule.rpo_order()->push_back(start);
   start->set_rpo_number(0);
 
   BasicBlock* t1block = AddBlockToSchedule(&schedule);
   BasicBlock* f1block = AddBlockToSchedule(&schedule);
   BasicBlock* m1block = AddBlockToSchedule(&schedule);
 
@@ skipping 61 matching lines @@
   NodeProperties::ChangeOp(loop, common()->Loop(2));
 
   effect_phi->InsertInput(zone(), 1, effect_phi);
   NodeProperties::ChangeOp(effect_phi, common()->EffectPhi(2));
 
   Node* heap_number = NumberConstant(0.5);
   Node* load = graph()->NewNode(
       simplified()->LoadField(AccessBuilder::ForHeapNumberValue()), heap_number,
       graph()->start(), loop);
 
-  Node* zero = graph()->NewNode(common()->Int32Constant(0));
-  Node* ret =
-      graph()->NewNode(common()->Return(), zero, load, effect_phi, if_true);
+  Node* ret = graph()->NewNode(common()->Return(), load, effect_phi, if_true);
 
   // Build the basic block structure.
   BasicBlock* start = schedule.start();
   schedule.rpo_order()->push_back(start);
   start->set_rpo_number(0);
 
   BasicBlock* lblock = AddBlockToSchedule(&schedule);
   BasicBlock* fblock = AddBlockToSchedule(&schedule);
   BasicBlock* rblock = AddBlockToSchedule(&schedule);
 
@@ skipping 87 matching lines @@
                             IsIfTrue(CaptureEq(&branch2_capture))),
                     IsMerge(IsIfFalse(AllOf(CaptureEq(&branch1_capture),
                                             IsBranch(cond1, control1))),
                             IsIfFalse(AllOf(CaptureEq(&branch2_capture),
                                             IsBranch(cond2, control2)))))));
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8