Revert of [turbofan] Support variable size argument popping in TF-generated functions

Revert of [turbofan] Support variable size argument popping in TF-generated functions (patchset #13 id:240001 of https://codereview.chromium.org/2446543002/ )

Reason for revert:
Seems to break arm64 sim debug and blocks roll:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/builds/3294

Original issue's description:
> [turbofan] Support variable size argument removal in TF-generated functions
>
> This is preparation for using TF to create builtins that handle variable number of
> arguments and have to remove these arguments dynamically from the stack upon
> return.
>
> The gist of the changes:
> - Added a second argument to the Return node which specifies the number of stack
>   slots to pop upon return in addition to those specified by the Linkage of the
>   compiled function.
> - Removed Tail -> Non-Tail fallback in the instruction selector. Since TF now should
>   handles all tail-call cases except where the return value type differs, this fallback
>   was not really useful and in fact caused unexpected behavior with variable
>   sized argument popping, since it wasn't possible to materialize a Return node
>   with the right pop count from the TailCall without additional context.
> - Modified existing Return generation to pass a constant zero as the additional
>   pop argument since the variable pop functionality
>
> LOG=N

TBR=bmeurer@chromium.org,mstarzinger@chromium.org,epertoso@chromium.org,danno@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
NOPRESUBMIT=true

Committed: https://crrev.com/c61902e072ee8cfdfde58642a3638f402021f579
Cr-Commit-Position: refs/heads/master@{#40691}

[Michael Achenbach, 2016-11-02 07:21:22]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2016-11-02 07:21:23]

Created Revert of [turbofan] Support variable size argument popping in
TF-generated functions

[commit-bot: I haz the power, 2016-11-02 07:21:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 07:25:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 07:25:03]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/27645)

[Michael Achenbach, 2016-11-02 07:36:57]

Description was changed from

==========
Revert of [turbofan] Support variable size argument popping in TF-generated
functions (patchset #13 id:240001 of https://codereview.chromium.org/2446543002/
)

Reason for revert:
Seems to break arm64 sim debug and blocks roll:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...

Original issue's description:
> [turbofan] Support variable size argument removal in TF-generated functions
> 
> This is preparation for using TF to create builtins that handle variable
number of
> arguments and have to remove these arguments dynamically from the stack upon
> return.
> 
> The gist of the changes:
> - Added a second argument to the Return node which specifies the number of
stack
>   slots to pop upon return in addition to those specified by the Linkage of
the 
>   compiled function.
> - Removed Tail -> Non-Tail fallback in the instruction selector. Since TF now
should
>   handles all tail-call cases except where the return value type differs, this
fallback
>   was not really useful and in fact caused unexpected behavior with variable 
>   sized argument popping, since it wasn't possible to materialize a Return
node
>   with the right pop count from the TailCall without additional context.
> - Modified existing Return generation to pass a constant zero as the
additional 
>   pop argument since the variable pop functionality 
> 
> LOG=N

TBR=bmeurer@chromium.org,mstarzinger@chromium.org,epertoso@chromium.org,danno...
# Not skipping CQ checks because original CL landed more than 1 days ago.
==========

to

==========
Revert of [turbofan] Support variable size argument popping in TF-generated
functions (patchset #13 id:240001 of https://codereview.chromium.org/2446543002/
)

Reason for revert:
Seems to break arm64 sim debug and blocks roll:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...

Original issue's description:
> [turbofan] Support variable size argument removal in TF-generated functions
> 
> This is preparation for using TF to create builtins that handle variable
number of
> arguments and have to remove these arguments dynamically from the stack upon
> return.
> 
> The gist of the changes:
> - Added a second argument to the Return node which specifies the number of
stack
>   slots to pop upon return in addition to those specified by the Linkage of
the 
>   compiled function.
> - Removed Tail -> Non-Tail fallback in the instruction selector. Since TF now
should
>   handles all tail-call cases except where the return value type differs, this
fallback
>   was not really useful and in fact caused unexpected behavior with variable 
>   sized argument popping, since it wasn't possible to materialize a Return
node
>   with the right pop count from the TailCall without additional context.
> - Modified existing Return generation to pass a constant zero as the
additional 
>   pop argument since the variable pop functionality 
> 
> LOG=N

TBR=bmeurer@chromium.org,mstarzinger@chromium.org,epertoso@chromium.org,danno...
# Not skipping CQ checks because original CL landed more than 1 days ago.
NOPRESUBMIT=true
==========

[Michael Achenbach, 2016-11-02 07:37:02]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-11-02 07:37:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 07:48:52]

Description was changed from

==========
Revert of [turbofan] Support variable size argument popping in TF-generated
functions (patchset #13 id:240001 of https://codereview.chromium.org/2446543002/
)

Reason for revert:
Seems to break arm64 sim debug and blocks roll:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...

Original issue's description:
> [turbofan] Support variable size argument removal in TF-generated functions
> 
> This is preparation for using TF to create builtins that handle variable
number of
> arguments and have to remove these arguments dynamically from the stack upon
> return.
> 
> The gist of the changes:
> - Added a second argument to the Return node which specifies the number of
stack
>   slots to pop upon return in addition to those specified by the Linkage of
the 
>   compiled function.
> - Removed Tail -> Non-Tail fallback in the instruction selector. Since TF now
should
>   handles all tail-call cases except where the return value type differs, this
fallback
>   was not really useful and in fact caused unexpected behavior with variable 
>   sized argument popping, since it wasn't possible to materialize a Return
node
>   with the right pop count from the TailCall without additional context.
> - Modified existing Return generation to pass a constant zero as the
additional 
>   pop argument since the variable pop functionality 
> 
> LOG=N

TBR=bmeurer@chromium.org,mstarzinger@chromium.org,epertoso@chromium.org,danno...
# Not skipping CQ checks because original CL landed more than 1 days ago.
NOPRESUBMIT=true
==========

to

==========
Revert of [turbofan] Support variable size argument popping in TF-generated
functions (patchset #13 id:240001 of https://codereview.chromium.org/2446543002/
)

Reason for revert:
Seems to break arm64 sim debug and blocks roll:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...

Original issue's description:
> [turbofan] Support variable size argument removal in TF-generated functions
> 
> This is preparation for using TF to create builtins that handle variable
number of
> arguments and have to remove these arguments dynamically from the stack upon
> return.
> 
> The gist of the changes:
> - Added a second argument to the Return node which specifies the number of
stack
>   slots to pop upon return in addition to those specified by the Linkage of
the 
>   compiled function.
> - Removed Tail -> Non-Tail fallback in the instruction selector. Since TF now
should
>   handles all tail-call cases except where the return value type differs, this
fallback
>   was not really useful and in fact caused unexpected behavior with variable 
>   sized argument popping, since it wasn't possible to materialize a Return
node
>   with the right pop count from the TailCall without additional context.
> - Modified existing Return generation to pass a constant zero as the
additional 
>   pop argument since the variable pop functionality 
> 
> LOG=N

TBR=bmeurer@chromium.org,mstarzinger@chromium.org,epertoso@chromium.org,danno...
# Not skipping CQ checks because original CL landed more than 1 days ago.
NOPRESUBMIT=true
==========

[commit-bot: I haz the power, 2016-11-02 07:48:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-17 22:18:58]

Description was changed from

==========
Revert of [turbofan] Support variable size argument popping in TF-generated
functions (patchset #13 id:240001 of https://codereview.chromium.org/2446543002/
)

Reason for revert:
Seems to break arm64 sim debug and blocks roll:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...

Original issue's description:
> [turbofan] Support variable size argument removal in TF-generated functions
> 
> This is preparation for using TF to create builtins that handle variable
number of
> arguments and have to remove these arguments dynamically from the stack upon
> return.
> 
> The gist of the changes:
> - Added a second argument to the Return node which specifies the number of
stack
>   slots to pop upon return in addition to those specified by the Linkage of
the 
>   compiled function.
> - Removed Tail -> Non-Tail fallback in the instruction selector. Since TF now
should
>   handles all tail-call cases except where the return value type differs, this
fallback
>   was not really useful and in fact caused unexpected behavior with variable 
>   sized argument popping, since it wasn't possible to materialize a Return
node
>   with the right pop count from the TailCall without additional context.
> - Modified existing Return generation to pass a constant zero as the
additional 
>   pop argument since the variable pop functionality 
> 
> LOG=N

TBR=bmeurer@chromium.org,mstarzinger@chromium.org,epertoso@chromium.org,danno...
# Not skipping CQ checks because original CL landed more than 1 days ago.
NOPRESUBMIT=true
==========

to

==========
Revert of [turbofan] Support variable size argument popping in TF-generated
functions (patchset #13 id:240001 of https://codereview.chromium.org/2446543002/
)

Reason for revert:
Seems to break arm64 sim debug and blocks roll:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%...

Original issue's description:
> [turbofan] Support variable size argument removal in TF-generated functions
>
> This is preparation for using TF to create builtins that handle variable
number of
> arguments and have to remove these arguments dynamically from the stack upon
> return.
>
> The gist of the changes:
> - Added a second argument to the Return node which specifies the number of
stack
>   slots to pop upon return in addition to those specified by the Linkage of
the
>   compiled function.
> - Removed Tail -> Non-Tail fallback in the instruction selector. Since TF now
should
>   handles all tail-call cases except where the return value type differs, this
fallback
>   was not really useful and in fact caused unexpected behavior with variable
>   sized argument popping, since it wasn't possible to materialize a Return
node
>   with the right pop count from the TailCall without additional context.
> - Modified existing Return generation to pass a constant zero as the
additional
>   pop argument since the variable pop functionality
>
> LOG=N

TBR=bmeurer@chromium.org,mstarzinger@chromium.org,epertoso@chromium.org,danno...
# Not skipping CQ checks because original CL landed more than 1 days ago.
NOPRESUBMIT=true

Committed: https://crrev.com/c61902e072ee8cfdfde58642a3638f402021f579
Cr-Commit-Position: refs/heads/master@{#40691}
==========

[commit-bot: I haz the power, 2016-11-17 22:19:00]

Patchset 1 (id:??) landed as
https://crrev.com/c61902e072ee8cfdfde58642a3638f402021f579
Cr-Commit-Position: refs/heads/master@{#40691}