Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2473633002: Add a nbsp at the the end of the text when the next text has a leading space. (Closed)

Created:
4 years, 1 month ago by yosin_UTC9
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Add a nbsp at the the end of the text when the next text has a leading space. This is a regression caused by https://codereview.chromium.org/2175163004. The above CL adds a plain space between text nodes, but a nbsp should be added if the next text node has a leading plain space. If not, two spaces are collapsed into one plain space. BUG=657631 TEST=editing/inserting/insert-space.html Review-Url: https://chromiumcodereview.appspot.com/2432083003 Cr-Commit-Position: refs/heads/master@{#426420} (cherry picked from commit 952d55918cdb455223cabf647cef859486a37b0f) Committed: https://chromium.googlesource.com/chromium/src/+/9ebff223d5d639167c3efb01a5fa912b3aee05a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/editing/inserting/insert-space.html View 2 chunks +14 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
yosin_UTC9
4 years, 1 month ago (2016-11-02 06:30:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9ebff223d5d639167c3efb01a5fa912b3aee05a9.

Powered by Google App Engine
This is Rietveld 408576698