Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 247363003: Update mojom parser to allow array of arrays. (Closed)

Created:
6 years, 8 months ago by qsr
Modified:
6 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Update mojom parser to allow array of arrays. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265356

Patch Set 1 #

Patch Set 2 : Adding unit tests #

Patch Set 3 : Fix js unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M mojo/bindings/js/codec_unittests.js View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/tests/sample_service_unittest.cc View 1 4 chunks +19 lines, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_service.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/parser.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
qsr
6 years, 8 months ago (2014-04-22 14:16:09 UTC) #1
darin (slow to review)
LGTM Do you want to extend sample_service_unittest.cc to use array_of_array_of_bools?
6 years, 8 months ago (2014-04-22 14:31:21 UTC) #2
qsr
On 2014/04/22 14:31:21, darin wrote: > LGTM > > Do you want to extend sample_service_unittest.cc ...
6 years, 8 months ago (2014-04-22 14:49:47 UTC) #3
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 8 months ago (2014-04-22 14:49:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/247363003/20001
6 years, 8 months ago (2014-04-22 14:50:13 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 16:35:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_x64_rel
6 years, 8 months ago (2014-04-22 16:35:04 UTC) #7
darin (slow to review)
Thanks for adding the test!
6 years, 8 months ago (2014-04-22 17:08:09 UTC) #8
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 8 months ago (2014-04-22 17:15:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/247363003/30001
6 years, 8 months ago (2014-04-22 17:16:26 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 21:01:08 UTC) #11
Message was sent while issue was closed.
Change committed as 265356

Powered by Google App Engine
This is Rietveld 408576698