[Sync] Adds a new switch for enabling the new local server backend.

Adds a new switch for enabling the new local server backend.

Actually two flags which play in tandem:

--enable-local-sync-backend and --local-sync-backend-dir

The second is respected only if the first one is specified.
Eventually those will be controlled by policy but the flags will allow
easier testing and potentially unlock the feature for advanced users.

For now sign-in is needed to kick the sync logic on but the data
is only stored locally when this flag is specified.

This CL is identical to https://codereview.chromium.org/2442453002/
with only a changed type of the kLoopbackServerBackendFilename
constant according to the size bot recommendation.

BUG=651411
TEST=unit_tests/manual.
TBR=pavely

Committed: https://crrev.com/43c6f026f1f50ed3e656f9c96f1b49b78afbfb18
Cr-Commit-Position: refs/heads/master@{#429558}

[pastarmovj, 2016-11-02 15:59:53]

Description was changed from

==========
Adds a new switch for enabling the new local server backend.

Actually two flags which play in tandem:

--enable-local-sync-backend and --local-sync-backend-dir

The second is respected only if the first one is specified.
Eventually those will be controlled by policy but the flags will allow
easier testing and potentially unlock the feature for advanced users.

For now sign-in is needed to kick the sync logic on but the data
is only stored locally when this flag is specified.

BUG=651411
TEST=unit_tests/manual.
==========

to

==========
Adds a new switch for enabling the new local server backend.

Actually two flags which play in tandem:

--enable-local-sync-backend and --local-sync-backend-dir

The second is respected only if the first one is specified.
Eventually those will be controlled by policy but the flags will allow
easier testing and potentially unlock the feature for advanced users.

For now sign-in is needed to kick the sync logic on but the data
is only stored locally when this flag is specified.

This CL is identical to https://codereview.chromium.org/2442453002/ with only a
changed type of the kLoopbackServerBackendFilename constant according to the
size bot recommendation.

BUG=651411
TEST=unit_tests/manual.
TBR=pavely
==========

[pastarmovj, 2016-11-02 16:32:33]

Description was changed from

==========
Adds a new switch for enabling the new local server backend.

Actually two flags which play in tandem:

--enable-local-sync-backend and --local-sync-backend-dir

The second is respected only if the first one is specified.
Eventually those will be controlled by policy but the flags will allow
easier testing and potentially unlock the feature for advanced users.

For now sign-in is needed to kick the sync logic on but the data
is only stored locally when this flag is specified.

This CL is identical to https://codereview.chromium.org/2442453002/ with only a
changed type of the kLoopbackServerBackendFilename constant according to the
size bot recommendation.

BUG=651411
TEST=unit_tests/manual.
TBR=pavely
==========

to

==========
Adds a new switch for enabling the new local server backend.

Actually two flags which play in tandem:

--enable-local-sync-backend and --local-sync-backend-dir

The second is respected only if the first one is specified.
Eventually those will be controlled by policy but the flags will allow
easier testing and potentially unlock the feature for advanced users.

For now sign-in is needed to kick the sync logic on but the data
is only stored locally when this flag is specified.

This CL is identical to  with only a changed type of the
 kLoopbackServerBackendFilename constant according to the size bot
 recommendation.

BUG=651411
TEST=unit_tests/manual.
TBR=pavely
==========

[pastarmovj, 2016-11-02 16:33:18]

Description was changed from

==========
Adds a new switch for enabling the new local server backend.

Actually two flags which play in tandem:

--enable-local-sync-backend and --local-sync-backend-dir

The second is respected only if the first one is specified.
Eventually those will be controlled by policy but the flags will allow
easier testing and potentially unlock the feature for advanced users.

For now sign-in is needed to kick the sync logic on but the data
is only stored locally when this flag is specified.

This CL is identical to  with only a changed type of the
 kLoopbackServerBackendFilename constant according to the size bot
 recommendation.

BUG=651411
TEST=unit_tests/manual.
TBR=pavely
==========

to

==========
Adds a new switch for enabling the new local server backend.

Actually two flags which play in tandem:

--enable-local-sync-backend and --local-sync-backend-dir

The second is respected only if the first one is specified.
Eventually those will be controlled by policy but the flags will allow
easier testing and potentially unlock the feature for advanced users.

For now sign-in is needed to kick the sync logic on but the data
is only stored locally when this flag is specified.

This CL is identical to https://codereview.chromium.org/2442453002/
with only a changed type of the kLoopbackServerBackendFilename
constant according to the size bot recommendation.

BUG=651411
TEST=unit_tests/manual.
TBR=pavely
==========

[pastarmovj, 2016-11-02 16:36:31]

pastarmovj@chromium.org changed reviewers:
+ pavely@chromium.org

[pastarmovj, 2016-11-02 16:36:32]

Hey Pavel,

I had to clone the CL you reviewed last week because it got reverted for a
wrongly typed FILE_PATH_LITERAL. I fixed it in this CL. I am going to TBR land
this since it is technically 99% the same CL and 100% the same logic. 

I will do so tomorrow though in case you'd rather want to have a look first.

Cheers,
Julian

[pastarmovj, 2016-11-03 08:41:18]

The CQ bit was checked by pastarmovj@chromium.org

[commit-bot: I haz the power, 2016-11-03 08:41:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 08:52:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 08:52:02]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[pastarmovj, 2016-11-03 08:56:06]

The CQ bit was checked by pastarmovj@chromium.org

[commit-bot: I haz the power, 2016-11-03 08:56:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 10:21:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 10:21:56]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[pastarmovj, 2016-11-03 11:46:52]

The CQ bit was checked by pastarmovj@chromium.org

[commit-bot: I haz the power, 2016-11-03 11:47:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 13:24:04]

Description was changed from

==========
Adds a new switch for enabling the new local server backend.

Actually two flags which play in tandem:

--enable-local-sync-backend and --local-sync-backend-dir

The second is respected only if the first one is specified.
Eventually those will be controlled by policy but the flags will allow
easier testing and potentially unlock the feature for advanced users.

For now sign-in is needed to kick the sync logic on but the data
is only stored locally when this flag is specified.

This CL is identical to https://codereview.chromium.org/2442453002/
with only a changed type of the kLoopbackServerBackendFilename
constant according to the size bot recommendation.

BUG=651411
TEST=unit_tests/manual.
TBR=pavely
==========

to

==========
Adds a new switch for enabling the new local server backend.

Actually two flags which play in tandem:

--enable-local-sync-backend and --local-sync-backend-dir

The second is respected only if the first one is specified.
Eventually those will be controlled by policy but the flags will allow
easier testing and potentially unlock the feature for advanced users.

For now sign-in is needed to kick the sync logic on but the data
is only stored locally when this flag is specified.

This CL is identical to https://codereview.chromium.org/2442453002/
with only a changed type of the kLoopbackServerBackendFilename
constant according to the size bot recommendation.

BUG=651411
TEST=unit_tests/manual.
TBR=pavely
==========

[commit-bot: I haz the power, 2016-11-03 13:24:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-03 13:27:56]

Description was changed from

==========
Adds a new switch for enabling the new local server backend.

Actually two flags which play in tandem:

--enable-local-sync-backend and --local-sync-backend-dir

The second is respected only if the first one is specified.
Eventually those will be controlled by policy but the flags will allow
easier testing and potentially unlock the feature for advanced users.

For now sign-in is needed to kick the sync logic on but the data
is only stored locally when this flag is specified.

This CL is identical to https://codereview.chromium.org/2442453002/
with only a changed type of the kLoopbackServerBackendFilename
constant according to the size bot recommendation.

BUG=651411
TEST=unit_tests/manual.
TBR=pavely
==========

to

==========
Adds a new switch for enabling the new local server backend.

Actually two flags which play in tandem:

--enable-local-sync-backend and --local-sync-backend-dir

The second is respected only if the first one is specified.
Eventually those will be controlled by policy but the flags will allow
easier testing and potentially unlock the feature for advanced users.

For now sign-in is needed to kick the sync logic on but the data
is only stored locally when this flag is specified.

This CL is identical to https://codereview.chromium.org/2442453002/
with only a changed type of the kLoopbackServerBackendFilename
constant according to the size bot recommendation.

BUG=651411
TEST=unit_tests/manual.
TBR=pavely

Committed: https://crrev.com/43c6f026f1f50ed3e656f9c96f1b49b78afbfb18
Cr-Commit-Position: refs/heads/master@{#429558}
==========

[commit-bot: I haz the power, 2016-11-03 13:27:57]

Patchset 2 (id:??) landed as
https://crrev.com/43c6f026f1f50ed3e656f9c96f1b49b78afbfb18
Cr-Commit-Position: refs/heads/master@{#429558}

[pavely, 2016-11-03 23:45:20]

lgtm

btw: to simplify review of reland you can first upload original change and then
adjust it and upload in separate patchset. This way it is easier to find what's
changed.