Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2473583002: Revert BrowserControlsOffsetManager changes (Closed)

Created:
4 years, 1 month ago by mdjones
Modified:
4 years, 1 month ago
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert BrowserControlsOffsetManager changes Reverts a change that found its way into https://codereview.chromium.org/2443613002/ after a bad rebase. BUG=652892 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/42d103c13520b26d8970b5a5fcf15d60fbe643c1 Cr-Commit-Position: refs/heads/master@{#429292}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -39 lines) Patch
M cc/input/browser_controls_offset_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/input/browser_controls_offset_manager.cc View 8 chunks +9 lines, -19 lines 0 comments Download
M cc/input/browser_controls_offset_manager_unittest.cc View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
mdjones
ptal
4 years, 1 month ago (2016-11-01 22:27:41 UTC) #3
aelias_OOO_until_Jul13
lgtm
4 years, 1 month ago (2016-11-01 22:29:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473583002/1
4 years, 1 month ago (2016-11-01 22:33:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/254438)
4 years, 1 month ago (2016-11-01 23:00:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473583002/1
4 years, 1 month ago (2016-11-01 23:11:07 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/254480)
4 years, 1 month ago (2016-11-02 00:01:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473583002/1
4 years, 1 month ago (2016-11-02 15:30:29 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 16:13:39 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 16:20:48 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42d103c13520b26d8970b5a5fcf15d60fbe643c1
Cr-Commit-Position: refs/heads/master@{#429292}

Powered by Google App Engine
This is Rietveld 408576698