Code cleanup: moving compiler perf tests to compiler/tool

Code cleanup: moving compiler perf tests to compiler/tool

Task as described in https://docs.google.com/spreadsheets/d/1zebkSp_VjVFC_vd2JufrOkrT5O1XVu6iyoCmusE_UEk/edit#gid=0&vpid=A1

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/de2697f41c302266ace65d124c216d8e9aa86ae5

[Emily Fortuna, 2016-11-03 21:20:59]

efortuna@google.com changed reviewers:
+ sigmund@google.com

[Emily Fortuna, 2016-11-03 21:21:00]

this is a hugely important change, I know. Now, back to ssa_builder!

[Emily Fortuna, 2016-11-03 21:21:38]

Description was changed from

==========
Code cleanup: moving compiler perf tests to compiler/tool
==========

to

==========
Code cleanup: moving compiler perf tests to compiler/tool

Task as described in
https://docs.google.com/spreadsheets/d/1zebkSp_VjVFC_vd2JufrOkrT5O1XVu6iyoCmu...
==========

[Siggi Cherem (dart-lang), 2016-11-03 21:38:41]

lgtm

https://codereview.chromium.org/2473553005/diff/20001/pkg/compiler/tool/dart2...
File pkg/compiler/tool/dart2js_profile_many.dart (right):

https://codereview.chromium.org/2473553005/diff/20001/pkg/compiler/tool/dart2...
pkg/compiler/tool/dart2js_profile_many.dart:9: import '../lib/src/dart2js.dart'
as cmdline;
now that this is outside the lib folder, we no longer use relative paths, you
can use "package:compiler/src/dart2js.dart" instead.

https://codereview.chromium.org/2473553005/diff/20001/pkg/compiler/tool/dart2...
File pkg/compiler/tool/dart2js_stress.dart (right):

https://codereview.chromium.org/2473553005/diff/20001/pkg/compiler/tool/dart2...
pkg/compiler/tool/dart2js_stress.dart:7: import "../lib/src/dart2js.dart" as
dart2js;
ditto

https://codereview.chromium.org/2473553005/diff/20001/pkg/compiler/tool/dart2...
pkg/compiler/tool/dart2js_stress.dart:25:
"--library-root=${Platform.script.toFilePath()}/../../../../sdk"]
in case we run this in windows, we might need to use the 'uriPathToNative' for
the suffix (../../../sdk), or we can do the relative path resolution through the
Uri class, and only convert to a path at the end. For instance:

  Platform.script.resolve('../../../sdk/').toFilePath()

[Emily Fortuna, 2016-11-03 22:26:13]

https://codereview.chromium.org/2473553005/diff/20001/pkg/compiler/tool/dart2...
File pkg/compiler/tool/dart2js_profile_many.dart (right):

https://codereview.chromium.org/2473553005/diff/20001/pkg/compiler/tool/dart2...
pkg/compiler/tool/dart2js_profile_many.dart:9: import '../lib/src/dart2js.dart'
as cmdline;
On 2016/11/03 21:38:40, Siggi Cherem (dart-lang) wrote:
> now that this is outside the lib folder, we no longer use relative paths, you
> can use "package:compiler/src/dart2js.dart" instead.

Done.

https://codereview.chromium.org/2473553005/diff/20001/pkg/compiler/tool/dart2...
File pkg/compiler/tool/dart2js_stress.dart (right):

https://codereview.chromium.org/2473553005/diff/20001/pkg/compiler/tool/dart2...
pkg/compiler/tool/dart2js_stress.dart:7: import "../lib/src/dart2js.dart" as
dart2js;
On 2016/11/03 21:38:40, Siggi Cherem (dart-lang) wrote:
> ditto

Done.

https://codereview.chromium.org/2473553005/diff/20001/pkg/compiler/tool/dart2...
pkg/compiler/tool/dart2js_stress.dart:25:
"--library-root=${Platform.script.toFilePath()}/../../../../sdk"]
On 2016/11/03 21:38:40, Siggi Cherem (dart-lang) wrote:
> in case we run this in windows, we might need to use the 'uriPathToNative' for
> the suffix (../../../sdk), or we can do the relative path resolution through
the
> Uri class, and only convert to a path at the end. For instance:
> 
>   Platform.script.resolve('../../../sdk/').toFilePath()

I wondered about that when I wrote this, though it looks like dart2js.dart was
hardcoding that ../.. path with the slashes as well so I thought it was okay.
But I'll do it correctly here.

[Emily Fortuna, 2016-11-03 22:29:02]

Description was changed from

==========
Code cleanup: moving compiler perf tests to compiler/tool

Task as described in
https://docs.google.com/spreadsheets/d/1zebkSp_VjVFC_vd2JufrOkrT5O1XVu6iyoCmu...
==========

to

==========
Code cleanup: moving compiler perf tests to compiler/tool

Task as described in
https://docs.google.com/spreadsheets/d/1zebkSp_VjVFC_vd2JufrOkrT5O1XVu6iyoCmu...

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/de2697f41c302266ace65d124c216d8e9aa86ae5
==========

[Emily Fortuna, 2016-11-03 22:29:03]

Committed patchset #3 (id:40001) manually as
de2697f41c302266ace65d124c216d8e9aa86ae5 (presubmit successful).

[Siggi Cherem (dart-lang), 2016-11-03 23:01:38]

On 2016/11/03 22:26:13, Emily Fortuna wrote:
>
https://codereview.chromium.org/2473553005/diff/20001/pkg/compiler/tool/dart2...
> File pkg/compiler/tool/dart2js_profile_many.dart (right):
> 
>
https://codereview.chromium.org/2473553005/diff/20001/pkg/compiler/tool/dart2...
> pkg/compiler/tool/dart2js_profile_many.dart:9: import
'../lib/src/dart2js.dart'
> as cmdline;
> On 2016/11/03 21:38:40, Siggi Cherem (dart-lang) wrote:
> > now that this is outside the lib folder, we no longer use relative paths,
you
> > can use "package:compiler/src/dart2js.dart" instead.
> 
> Done.
> 
>
https://codereview.chromium.org/2473553005/diff/20001/pkg/compiler/tool/dart2...
> File pkg/compiler/tool/dart2js_stress.dart (right):
> 
>
https://codereview.chromium.org/2473553005/diff/20001/pkg/compiler/tool/dart2...
> pkg/compiler/tool/dart2js_stress.dart:7: import "../lib/src/dart2js.dart" as
> dart2js;
> On 2016/11/03 21:38:40, Siggi Cherem (dart-lang) wrote:
> > ditto
> 
> Done.
> 
>
https://codereview.chromium.org/2473553005/diff/20001/pkg/compiler/tool/dart2...
> pkg/compiler/tool/dart2js_stress.dart:25:
> "--library-root=${Platform.script.toFilePath()}/../../../../sdk"]
> On 2016/11/03 21:38:40, Siggi Cherem (dart-lang) wrote:
> > in case we run this in windows, we might need to use the 'uriPathToNative'
for
> > the suffix (../../../sdk), or we can do the relative path resolution through
> the
> > Uri class, and only convert to a path at the end. For instance:
> > 
> >   Platform.script.resolve('../../../sdk/').toFilePath()
> 
> I wondered about that when I wrote this, though it looks like dart2js.dart was
> hardcoding that ../.. path with the slashes as well so I thought it was okay.
> But I'll do it correctly here.

yeah - it's odd how it's done there. The "uriPathToNative" call fixes the
slashes, but the fact that we just add it after the filename (rather than
starting from the dir) seems pretty odd.