Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: components/offline_pages/background/request_queue_unittest.cc

Issue 2473553004: Request Picker task (Closed)
Patch Set: CR fixes per DougArnett Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue_unittest.cc
diff --git a/components/offline_pages/background/request_queue_unittest.cc b/components/offline_pages/background/request_queue_unittest.cc
index 1898d818936130867b301fa66fce43d0fba46c69..614b8be3e5ffc5d8f762c24a406c60b34b354a2f 100644
--- a/components/offline_pages/background/request_queue_unittest.cc
+++ b/components/offline_pages/background/request_queue_unittest.cc
@@ -16,9 +16,9 @@
namespace offline_pages {
-using AddRequestResult = RequestQueue::AddRequestResult;
-using GetRequestsResult = RequestQueue::GetRequestsResult;
-using UpdateRequestResult = RequestQueue::UpdateRequestResult;
+using AddRequestResult = QueueResults::AddRequestResult;
+using GetRequestsResult = QueueResults::GetRequestsResult;
+using UpdateRequestResult = QueueResults::UpdateRequestResult;
namespace {
// Data for request 1.
@@ -51,7 +51,8 @@ class RequestQueueTest : public testing::Test {
std::vector<std::unique_ptr<SavePageRequest>> requests);
void UpdateRequestDone(UpdateRequestResult result);
- void UpdateRequestsDone(std::unique_ptr<UpdateRequestsResult> result);
+ void UpdateRequestsDone(
+ std::unique_ptr<QueueResults::UpdateRequestsResult> result);
void ClearResults();
@@ -72,14 +73,14 @@ class RequestQueueTest : public testing::Test {
return last_requests_;
}
- UpdateRequestsResult* update_requests_result() const {
+ QueueResults::UpdateRequestsResult* update_requests_result() const {
return update_requests_result_.get();
}
private:
AddRequestResult last_add_result_;
std::unique_ptr<SavePageRequest> last_added_request_;
- std::unique_ptr<UpdateRequestsResult> update_requests_result_;
+ std::unique_ptr<QueueResults::UpdateRequestsResult> update_requests_result_;
UpdateRequestResult last_update_result_;
GetRequestsResult last_get_requests_result_;
@@ -127,7 +128,7 @@ void RequestQueueTest::UpdateRequestDone(UpdateRequestResult result) {
}
void RequestQueueTest::UpdateRequestsDone(
- std::unique_ptr<UpdateRequestsResult> result) {
+ std::unique_ptr<QueueResults::UpdateRequestsResult> result) {
update_requests_result_ = std::move(result);
}

Powered by Google App Engine
This is Rietveld 408576698