Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3570)

Unified Diff: components/offline_pages/background/request_queue_store_sql.cc

Issue 2473553004: Request Picker task (Closed)
Patch Set: CR fixes per DougArnett Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue_store_sql.cc
diff --git a/components/offline_pages/background/request_queue_store_sql.cc b/components/offline_pages/background/request_queue_store_sql.cc
index b008ed33141baa5df5742c5f733adf80a979f99b..472c92e9b56f610b607cb0bbe1c3f30fe230aa57 100644
--- a/components/offline_pages/background/request_queue_store_sql.cc
+++ b/components/offline_pages/background/request_queue_store_sql.cc
@@ -188,8 +188,8 @@ void PostStoreUpdateResultForIds(
const std::vector<int64_t>& item_ids,
ItemActionStatus action_status,
const RequestQueueStore::UpdateCallback& callback) {
- std::unique_ptr<UpdateRequestsResult> result(
- new UpdateRequestsResult(store_state));
+ std::unique_ptr<QueueResults::UpdateRequestsResult> result(
+ new QueueResults::UpdateRequestsResult(store_state));
for (const auto& item_id : item_ids)
result->item_statuses.push_back(std::make_pair(item_id, action_status));
runner->PostTask(FROM_HERE, base::Bind(callback, base::Passed(&result)));
@@ -254,8 +254,8 @@ void GetRequestsByIdsSync(sql::Connection* db,
const std::vector<int64_t>& request_ids,
const RequestQueueStore::UpdateCallback& callback) {
// TODO(fgorski): Perhaps add metrics here.
- std::unique_ptr<UpdateRequestsResult> result(
- new UpdateRequestsResult(StoreState::LOADED));
+ std::unique_ptr<QueueResults::UpdateRequestsResult> result(
+ new QueueResults::UpdateRequestsResult(StoreState::LOADED));
// If you create a transaction but don't Commit() it is automatically
// rolled back by its destructor when it falls out of scope.
@@ -301,8 +301,8 @@ void UpdateRequestsSync(sql::Connection* db,
const std::vector<SavePageRequest>& requests,
const RequestQueueStore::UpdateCallback& callback) {
// TODO(fgorski): add UMA metrics here.
- std::unique_ptr<UpdateRequestsResult> result(
- new UpdateRequestsResult(StoreState::LOADED));
+ std::unique_ptr<QueueResults::UpdateRequestsResult> result(
+ new QueueResults::UpdateRequestsResult(StoreState::LOADED));
sql::Transaction transaction(db);
if (!transaction.Begin()) {
@@ -331,8 +331,8 @@ void RemoveRequestsSync(sql::Connection* db,
const std::vector<int64_t>& request_ids,
const RequestQueueStore::UpdateCallback& callback) {
// TODO(fgorski): Perhaps add metrics here.
- std::unique_ptr<UpdateRequestsResult> result(
- new UpdateRequestsResult(StoreState::LOADED));
+ std::unique_ptr<QueueResults::UpdateRequestsResult> result(
+ new QueueResults::UpdateRequestsResult(StoreState::LOADED));
// If you create a transaction but don't Commit() it is automatically
// rolled back by its destructor when it falls out of scope.

Powered by Google App Engine
This is Rietveld 408576698