components/offline_pages/background/request_coordinator_event_logger_unittest.cc - Issue 2473553004: Request Picker task

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_coordinator_event_logger_unittest.cc

Issue 2473553004: Request Picker task (Closed)

Patch Set: CR fixes per DougArnett Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/offline_pages/background/pick_request_task_builder.h ('K') | « components/offline_pages/background/request_coordinator_event_logger.cc ('k') | components/offline_pages/background/request_coordinator_unittest.cc » ('j') | components/offline_pages/background/request_queue.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/background/request_coordinator_event_logger_unittest.cc

diff --git a/components/offline_pages/background/request_coordinator_event_logger_unittest.cc b/components/offline_pages/background/request_coordinator_event_logger_unittest.cc

index e41702b49fb7b94b1b4704d8931d463d635eef46..8e6b35e663a9975011d6339bc0e71cadb096a132 100644

--- a/components/offline_pages/background/request_coordinator_event_logger_unittest.cc

+++ b/components/offline_pages/background/request_coordinator_event_logger_unittest.cc

@@ -15,8 +15,8 @@ const Offliner::RequestStatus kOfflinerStatus = Offliner::SAVED;

const RequestNotifier::BackgroundSavePageResult kDroppedResult =

RequestNotifier::BackgroundSavePageResult::START_COUNT_EXCEEDED;

const int64_t kId = 1234;

-const RequestQueue::UpdateRequestResult kQueueUpdateResult =

- RequestQueue::UpdateRequestResult::STORE_FAILURE;

+const QueueResults::UpdateRequestResult kQueueUpdateResult =

+ QueueResults::UpdateRequestResult::STORE_FAILURE;

const char kOfflinerStatusLogString[] =

"Background save attempt for last_n:1234 - SAVED";