components/offline_pages/background/mark_attempt_completed_task.cc - Issue 2473553004: Request Picker task

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/mark_attempt_completed_task.cc

Issue 2473553004: Request Picker task (Closed)

Patch Set: CR fixes per DougArnett Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/background/mark_attempt_completed_task.cc

diff --git a/components/offline_pages/background/mark_attempt_completed_task.cc b/components/offline_pages/background/mark_attempt_completed_task.cc

index d3ec900f488cf62bebd3a647780cbbd9ff36b50c..7457296f60b1bec5f14d900e7c2ad2196042920c 100644

--- a/components/offline_pages/background/mark_attempt_completed_task.cc

+++ b/components/offline_pages/background/mark_attempt_completed_task.cc

@@ -20,7 +20,7 @@ MarkAttemptCompletedTask::MarkAttemptCompletedTask(

MarkAttemptCompletedTask::~MarkAttemptCompletedTask() {}

void MarkAttemptCompletedTask::UpdateRequestImpl(

- std::unique_ptr<UpdateRequestsResult> read_result) {

+ std::unique_ptr<QueueResults::UpdateRequestsResult> read_result) {

if (!ValidateReadResult(read_result.get())) {

CompleteWithResult(std::move(read_result));

return;