Request Picker task

components/offline_pages/background/queue_results.h

Index: components/offline_pages/background/queue_results.h
diff --git a/components/offline_pages/background/queue_results.h b/components/offline_pages/background/queue_results.h
new file mode 100644
index 0000000000000000000000000000000000000000..dc3e220874d6e38ca9a2acbfc18d22efb64ffeb5
--- /dev/null
+++ b/components/offline_pages/background/queue_results.h
@@ -0,0 +1,42 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_QUEUE_RESULTS_H_
+#define COMPONENTS_OFFLINE_PAGES_BACKGROUND_QUEUE_RESULTS_H_
+
+#include "components/offline_pages/background/save_page_request.h"
+#include "components/offline_pages/offline_store_types.h"
+
+namespace offline_pages {
+
+// Extracted from RequestQueue so that we can build types that use these results
+// that RequestQueue depends on (for example, the PickRequestTask).
+struct QueueResults {

[Evan Stade, 2016/11/08 14:40:30]

why this struct? seems like these types can be first-class members of the
offline_pages namespace.

offline_pages::QueueResults::GetRequestsResult::SUCCESS is just a little bit too
verbose imo.

[Pete Williamson, 2016/11/08 22:13:53]

Done.

+  typedef StoreUpdateResult<SavePageRequest> UpdateRequestsResult;
+
+  enum class GetRequestsResult {
+    SUCCESS,
+    STORE_FAILURE,
+  };
+
+  enum class AddRequestResult {
+    SUCCESS,
+    STORE_FAILURE,
+    ALREADY_EXISTS,
+    REQUEST_QUOTA_HIT,  // Cannot add a request with this namespace, as it has
+                        // reached a quota of active requests.
+  };
+
+  // GENERATED_JAVA_ENUM_PACKAGE:org.chromium.components.offlinepages.background
+  enum class UpdateRequestResult {
+    SUCCESS,
+    STORE_FAILURE,
+    REQUEST_DOES_NOT_EXIST,  // Failed to delete the request because it does not
+                             // exist.
+  };
+};
+
+}  // namespace offline_pages
+
+#endif  // COMPONENTS_OFFLINE_PAGES_BACKGROUND_QUEUE_RESULTS_H_