Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Side by Side Diff: components/offline_pages/background/request_queue_store_unittest.cc

Issue 2473553004: Request Picker task (Closed)
Patch Set: CR fixes per DougArnett Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/background/request_queue_store.h" 5 #include "components/offline_pages/background/request_queue_store.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 51
52 void PumpLoop(); 52 void PumpLoop();
53 void ClearResults(); 53 void ClearResults();
54 54
55 // Callback used for get requests. 55 // Callback used for get requests.
56 void GetRequestsDone(bool result, 56 void GetRequestsDone(bool result,
57 std::vector<std::unique_ptr<SavePageRequest>> requests); 57 std::vector<std::unique_ptr<SavePageRequest>> requests);
58 // Callback used for add/update request. 58 // Callback used for add/update request.
59 void AddOrUpdateDone(UpdateStatus result); 59 void AddOrUpdateDone(UpdateStatus result);
60 void AddRequestDone(ItemActionStatus status); 60 void AddRequestDone(ItemActionStatus status);
61 void UpdateRequestDone(std::unique_ptr<UpdateRequestsResult> result); 61 void UpdateRequestDone(
62 std::unique_ptr<QueueResults::UpdateRequestsResult> result);
62 // Callback used for reset. 63 // Callback used for reset.
63 void ResetDone(bool result); 64 void ResetDone(bool result);
64 65
65 LastResult last_result() const { return last_result_; } 66 LastResult last_result() const { return last_result_; }
66 UpdateStatus last_update_status() const { return last_update_status_; } 67 UpdateStatus last_update_status() const { return last_update_status_; }
67 const std::vector<std::unique_ptr<SavePageRequest>>& last_requests() const { 68 const std::vector<std::unique_ptr<SavePageRequest>>& last_requests() const {
68 return last_requests_; 69 return last_requests_;
69 } 70 }
70 ItemActionStatus last_add_status() const { return last_add_status_; } 71 ItemActionStatus last_add_status() const { return last_add_status_; }
71 72
72 UpdateRequestsResult* last_update_result() const { 73 QueueResults::UpdateRequestsResult* last_update_result() const {
73 return last_update_result_.get(); 74 return last_update_result_.get();
74 } 75 }
75 76
76 protected: 77 protected:
77 base::ScopedTempDir temp_directory_; 78 base::ScopedTempDir temp_directory_;
78 79
79 private: 80 private:
80 LastResult last_result_; 81 LastResult last_result_;
81 UpdateStatus last_update_status_; 82 UpdateStatus last_update_status_;
82 ItemActionStatus last_add_status_; 83 ItemActionStatus last_add_status_;
83 std::unique_ptr<UpdateRequestsResult> last_update_result_; 84 std::unique_ptr<QueueResults::UpdateRequestsResult> last_update_result_;
84 std::vector<std::unique_ptr<SavePageRequest>> last_requests_; 85 std::vector<std::unique_ptr<SavePageRequest>> last_requests_;
85 86
86 scoped_refptr<base::TestSimpleTaskRunner> task_runner_; 87 scoped_refptr<base::TestSimpleTaskRunner> task_runner_;
87 base::ThreadTaskRunnerHandle task_runner_handle_; 88 base::ThreadTaskRunnerHandle task_runner_handle_;
88 }; 89 };
89 90
90 RequestQueueStoreTestBase::RequestQueueStoreTestBase() 91 RequestQueueStoreTestBase::RequestQueueStoreTestBase()
91 : last_result_(LastResult::kNone), 92 : last_result_(LastResult::kNone),
92 last_update_status_(UpdateStatus::FAILED), 93 last_update_status_(UpdateStatus::FAILED),
93 last_add_status_(ItemActionStatus::NOT_FOUND), 94 last_add_status_(ItemActionStatus::NOT_FOUND),
(...skipping 28 matching lines...) Expand all
122 123
123 void RequestQueueStoreTestBase::AddOrUpdateDone(UpdateStatus status) { 124 void RequestQueueStoreTestBase::AddOrUpdateDone(UpdateStatus status) {
124 last_update_status_ = status; 125 last_update_status_ = status;
125 } 126 }
126 127
127 void RequestQueueStoreTestBase::AddRequestDone(ItemActionStatus status) { 128 void RequestQueueStoreTestBase::AddRequestDone(ItemActionStatus status) {
128 last_add_status_ = status; 129 last_add_status_ = status;
129 } 130 }
130 131
131 void RequestQueueStoreTestBase::UpdateRequestDone( 132 void RequestQueueStoreTestBase::UpdateRequestDone(
132 std::unique_ptr<UpdateRequestsResult> result) { 133 std::unique_ptr<QueueResults::UpdateRequestsResult> result) {
133 last_update_result_ = std::move(result); 134 last_update_result_ = std::move(result);
134 } 135 }
135 136
136 void RequestQueueStoreTestBase::ResetDone(bool result) { 137 void RequestQueueStoreTestBase::ResetDone(bool result) {
137 last_result_ = result ? LastResult::kTrue : LastResult::kFalse; 138 last_result_ = result ? LastResult::kTrue : LastResult::kFalse;
138 } 139 }
139 140
140 // Defines interface for the store factory. 141 // Defines interface for the store factory.
141 class RequestQueueStoreFactory { 142 class RequestQueueStoreFactory {
142 public: 143 public:
(...skipping 320 matching lines...) Expand 10 before | Expand all | Expand 10 after
463 store->GetRequests(base::Bind(&RequestQueueStoreTestBase::GetRequestsDone, 464 store->GetRequests(base::Bind(&RequestQueueStoreTestBase::GetRequestsDone,
464 base::Unretained(this))); 465 base::Unretained(this)));
465 ASSERT_EQ(LastResult::kNone, this->last_result()); 466 ASSERT_EQ(LastResult::kNone, this->last_result());
466 this->PumpLoop(); 467 this->PumpLoop();
467 ASSERT_EQ(LastResult::kTrue, this->last_result()); 468 ASSERT_EQ(LastResult::kTrue, this->last_result());
468 ASSERT_EQ(1ul, this->last_requests().size()); 469 ASSERT_EQ(1ul, this->last_requests().size());
469 ASSERT_TRUE(original_request == *(this->last_requests().at(0).get())); 470 ASSERT_TRUE(original_request == *(this->last_requests().at(0).get()));
470 } 471 }
471 472
472 } // offline_pages 473 } // offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698