Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: components/offline_pages/background/remove_requests_task_unittest.cc

Issue 2473553004: Request Picker task (Closed)
Patch Set: CR fixes per DougArnett Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/background/remove_requests_task.h" 5 #include "components/offline_pages/background/remove_requests_task.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/test/test_simple_task_runner.h" 10 #include "base/test/test_simple_task_runner.h"
(...skipping 16 matching lines...) Expand all
27 public: 27 public:
28 RemoveRequestsTaskTest(); 28 RemoveRequestsTaskTest();
29 ~RemoveRequestsTaskTest() override; 29 ~RemoveRequestsTaskTest() override;
30 30
31 void PumpLoop(); 31 void PumpLoop();
32 32
33 void AddRequestsToStore(RequestQueueStore* store); 33 void AddRequestsToStore(RequestQueueStore* store);
34 34
35 void AddRequestDone(ItemActionStatus status); 35 void AddRequestDone(ItemActionStatus status);
36 36
37 void RemoveRequestsCallback(std::unique_ptr<UpdateRequestsResult> result); 37 void RemoveRequestsCallback(
38 std::unique_ptr<QueueResults::UpdateRequestsResult> result);
38 39
39 UpdateRequestsResult* last_result() const { return result_.get(); } 40 QueueResults::UpdateRequestsResult* last_result() const {
41 return result_.get();
42 }
40 43
41 private: 44 private:
42 std::unique_ptr<UpdateRequestsResult> result_; 45 std::unique_ptr<QueueResults::UpdateRequestsResult> result_;
43 scoped_refptr<base::TestSimpleTaskRunner> task_runner_; 46 scoped_refptr<base::TestSimpleTaskRunner> task_runner_;
44 base::ThreadTaskRunnerHandle task_runner_handle_; 47 base::ThreadTaskRunnerHandle task_runner_handle_;
45 }; 48 };
46 49
47 RemoveRequestsTaskTest::RemoveRequestsTaskTest() 50 RemoveRequestsTaskTest::RemoveRequestsTaskTest()
48 : task_runner_(new base::TestSimpleTaskRunner), 51 : task_runner_(new base::TestSimpleTaskRunner),
49 task_runner_handle_(task_runner_) {} 52 task_runner_handle_(task_runner_) {}
50 53
51 RemoveRequestsTaskTest::~RemoveRequestsTaskTest() {} 54 RemoveRequestsTaskTest::~RemoveRequestsTaskTest() {}
52 55
(...skipping 14 matching lines...) Expand all
67 base::Bind(&RemoveRequestsTaskTest::AddRequestDone, 70 base::Bind(&RemoveRequestsTaskTest::AddRequestDone,
68 base::Unretained(this))); 71 base::Unretained(this)));
69 PumpLoop(); 72 PumpLoop();
70 } 73 }
71 74
72 void RemoveRequestsTaskTest::AddRequestDone(ItemActionStatus status) { 75 void RemoveRequestsTaskTest::AddRequestDone(ItemActionStatus status) {
73 ASSERT_EQ(ItemActionStatus::SUCCESS, status); 76 ASSERT_EQ(ItemActionStatus::SUCCESS, status);
74 } 77 }
75 78
76 void RemoveRequestsTaskTest::RemoveRequestsCallback( 79 void RemoveRequestsTaskTest::RemoveRequestsCallback(
77 std::unique_ptr<UpdateRequestsResult> result) { 80 std::unique_ptr<QueueResults::UpdateRequestsResult> result) {
78 result_ = std::move(result); 81 result_ = std::move(result);
79 } 82 }
80 83
81 TEST_F(RemoveRequestsTaskTest, RemoveWhenStoreEmpty) { 84 TEST_F(RemoveRequestsTaskTest, RemoveWhenStoreEmpty) {
82 RequestQueueInMemoryStore store; 85 RequestQueueInMemoryStore store;
83 std::vector<int64_t> request_ids{kRequestId1}; 86 std::vector<int64_t> request_ids{kRequestId1};
84 RemoveRequestsTask task( 87 RemoveRequestsTask task(
85 &store, request_ids, 88 &store, request_ids,
86 base::Bind(&RemoveRequestsTaskTest::RemoveRequestsCallback, 89 base::Bind(&RemoveRequestsTaskTest::RemoveRequestsCallback,
87 base::Unretained(this))); 90 base::Unretained(this)));
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 EXPECT_EQ(ItemActionStatus::SUCCESS, 170 EXPECT_EQ(ItemActionStatus::SUCCESS,
168 last_result()->item_statuses.at(0).second); 171 last_result()->item_statuses.at(0).second);
169 EXPECT_EQ(kRequestId3, last_result()->item_statuses.at(1).first); 172 EXPECT_EQ(kRequestId3, last_result()->item_statuses.at(1).first);
170 EXPECT_EQ(ItemActionStatus::NOT_FOUND, 173 EXPECT_EQ(ItemActionStatus::NOT_FOUND,
171 last_result()->item_statuses.at(1).second); 174 last_result()->item_statuses.at(1).second);
172 EXPECT_EQ(1UL, last_result()->updated_items.size()); 175 EXPECT_EQ(1UL, last_result()->updated_items.size());
173 EXPECT_EQ(kRequestId1, last_result()->updated_items.at(0).request_id()); 176 EXPECT_EQ(kRequestId1, last_result()->updated_items.at(0).request_id());
174 } 177 }
175 178
176 } // namespace offline_pages 179 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698