Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Side by Side Diff: components/offline_pages/background/mark_attempt_started_task_unittest.cc

Issue 2473553004: Request Picker task (Closed)
Patch Set: CR fixes per DougArnett Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/background/mark_attempt_started_task.h" 5 #include "components/offline_pages/background/mark_attempt_started_task.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/test/test_simple_task_runner.h" 10 #include "base/test/test_simple_task_runner.h"
(...skipping 14 matching lines...) Expand all
25 MarkAttemptStartedTaskTest(); 25 MarkAttemptStartedTaskTest();
26 ~MarkAttemptStartedTaskTest() override; 26 ~MarkAttemptStartedTaskTest() override;
27 27
28 void PumpLoop(); 28 void PumpLoop();
29 29
30 void AddItemToStore(RequestQueueStore* store); 30 void AddItemToStore(RequestQueueStore* store);
31 31
32 void AddRequestDone(ItemActionStatus status); 32 void AddRequestDone(ItemActionStatus status);
33 33
34 void ChangeRequestsStateCallback( 34 void ChangeRequestsStateCallback(
35 std::unique_ptr<UpdateRequestsResult> result); 35 std::unique_ptr<QueueResults::UpdateRequestsResult> result);
36 36
37 UpdateRequestsResult* last_result() const { return result_.get(); } 37 QueueResults::UpdateRequestsResult* last_result() const {
38 return result_.get();
39 }
38 40
39 private: 41 private:
40 std::unique_ptr<UpdateRequestsResult> result_; 42 std::unique_ptr<QueueResults::UpdateRequestsResult> result_;
41 scoped_refptr<base::TestSimpleTaskRunner> task_runner_; 43 scoped_refptr<base::TestSimpleTaskRunner> task_runner_;
42 base::ThreadTaskRunnerHandle task_runner_handle_; 44 base::ThreadTaskRunnerHandle task_runner_handle_;
43 }; 45 };
44 46
45 MarkAttemptStartedTaskTest::MarkAttemptStartedTaskTest() 47 MarkAttemptStartedTaskTest::MarkAttemptStartedTaskTest()
46 : task_runner_(new base::TestSimpleTaskRunner), 48 : task_runner_(new base::TestSimpleTaskRunner),
47 task_runner_handle_(task_runner_) {} 49 task_runner_handle_(task_runner_) {}
48 50
49 MarkAttemptStartedTaskTest::~MarkAttemptStartedTaskTest() {} 51 MarkAttemptStartedTaskTest::~MarkAttemptStartedTaskTest() {}
50 52
51 void MarkAttemptStartedTaskTest::PumpLoop() { 53 void MarkAttemptStartedTaskTest::PumpLoop() {
52 task_runner_->RunUntilIdle(); 54 task_runner_->RunUntilIdle();
53 } 55 }
54 56
55 void MarkAttemptStartedTaskTest::AddItemToStore(RequestQueueStore* store) { 57 void MarkAttemptStartedTaskTest::AddItemToStore(RequestQueueStore* store) {
56 base::Time creation_time = base::Time::Now(); 58 base::Time creation_time = base::Time::Now();
57 SavePageRequest request_1(kRequestId1, kUrl1, kClientId1, creation_time, 59 SavePageRequest request_1(kRequestId1, kUrl1, kClientId1, creation_time,
58 true); 60 true);
59 store->AddRequest(request_1, 61 store->AddRequest(request_1,
60 base::Bind(&MarkAttemptStartedTaskTest::AddRequestDone, 62 base::Bind(&MarkAttemptStartedTaskTest::AddRequestDone,
61 base::Unretained(this))); 63 base::Unretained(this)));
62 PumpLoop(); 64 PumpLoop();
63 } 65 }
64 66
65 void MarkAttemptStartedTaskTest::AddRequestDone(ItemActionStatus status) { 67 void MarkAttemptStartedTaskTest::AddRequestDone(ItemActionStatus status) {
66 ASSERT_EQ(ItemActionStatus::SUCCESS, status); 68 ASSERT_EQ(ItemActionStatus::SUCCESS, status);
67 } 69 }
68 70
69 void MarkAttemptStartedTaskTest::ChangeRequestsStateCallback( 71 void MarkAttemptStartedTaskTest::ChangeRequestsStateCallback(
70 std::unique_ptr<UpdateRequestsResult> result) { 72 std::unique_ptr<QueueResults::UpdateRequestsResult> result) {
71 result_ = std::move(result); 73 result_ = std::move(result);
72 } 74 }
73 75
74 TEST_F(MarkAttemptStartedTaskTest, MarkAttemptStartedWhenStoreEmpty) { 76 TEST_F(MarkAttemptStartedTaskTest, MarkAttemptStartedWhenStoreEmpty) {
75 RequestQueueInMemoryStore store; 77 RequestQueueInMemoryStore store;
76 MarkAttemptStartedTask task( 78 MarkAttemptStartedTask task(
77 &store, kRequestId1, 79 &store, kRequestId1,
78 base::Bind(&MarkAttemptStartedTaskTest::ChangeRequestsStateCallback, 80 base::Bind(&MarkAttemptStartedTaskTest::ChangeRequestsStateCallback,
79 base::Unretained(this))); 81 base::Unretained(this)));
80 task.Run(); 82 task.Run();
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 PumpLoop(); 128 PumpLoop();
127 ASSERT_TRUE(last_result()); 129 ASSERT_TRUE(last_result());
128 EXPECT_EQ(1UL, last_result()->item_statuses.size()); 130 EXPECT_EQ(1UL, last_result()->item_statuses.size());
129 EXPECT_EQ(kRequestId2, last_result()->item_statuses.at(0).first); 131 EXPECT_EQ(kRequestId2, last_result()->item_statuses.at(0).first);
130 EXPECT_EQ(ItemActionStatus::NOT_FOUND, 132 EXPECT_EQ(ItemActionStatus::NOT_FOUND,
131 last_result()->item_statuses.at(0).second); 133 last_result()->item_statuses.at(0).second);
132 EXPECT_EQ(0UL, last_result()->updated_items.size()); 134 EXPECT_EQ(0UL, last_result()->updated_items.size());
133 } 135 }
134 136
135 } // namespace offline_pages 137 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698