Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: components/offline_pages/background/mark_attempt_started_task.cc

Issue 2473553004: Request Picker task (Closed)
Patch Set: CR fixes per DougArnett Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/background/mark_attempt_started_task.h" 5 #include "components/offline_pages/background/mark_attempt_started_task.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
11 11
12 namespace offline_pages { 12 namespace offline_pages {
13 13
14 MarkAttemptStartedTask::MarkAttemptStartedTask( 14 MarkAttemptStartedTask::MarkAttemptStartedTask(
15 RequestQueueStore* store, 15 RequestQueueStore* store,
16 int64_t request_id, 16 int64_t request_id,
17 const RequestQueueStore::UpdateCallback& callback) 17 const RequestQueueStore::UpdateCallback& callback)
18 : UpdateRequestTask(store, request_id, callback) {} 18 : UpdateRequestTask(store, request_id, callback) {}
19 19
20 MarkAttemptStartedTask::~MarkAttemptStartedTask() {} 20 MarkAttemptStartedTask::~MarkAttemptStartedTask() {}
21 21
22 void MarkAttemptStartedTask::UpdateRequestImpl( 22 void MarkAttemptStartedTask::UpdateRequestImpl(
23 std::unique_ptr<UpdateRequestsResult> read_result) { 23 std::unique_ptr<QueueResults::UpdateRequestsResult> read_result) {
24 if (!ValidateReadResult(read_result.get())) { 24 if (!ValidateReadResult(read_result.get())) {
25 CompleteWithResult(std::move(read_result)); 25 CompleteWithResult(std::move(read_result));
26 return; 26 return;
27 } 27 }
28 28
29 // It is perfectly fine to reuse the read_result->updated_items collection, as 29 // It is perfectly fine to reuse the read_result->updated_items collection, as
30 // it is owned by this callback and will be destroyed when out of scope. 30 // it is owned by this callback and will be destroyed when out of scope.
31 read_result->updated_items[0].MarkAttemptStarted(base::Time::Now()); 31 read_result->updated_items[0].MarkAttemptStarted(base::Time::Now());
32 store()->UpdateRequests( 32 store()->UpdateRequests(
33 read_result->updated_items, 33 read_result->updated_items,
34 base::Bind(&MarkAttemptStartedTask::CompleteWithResult, GetWeakPtr())); 34 base::Bind(&MarkAttemptStartedTask::CompleteWithResult, GetWeakPtr()));
35 } 35 }
36 36
37 } // namespace offline_pages 37 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698