Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: components/offline_pages/background/mark_attempt_completed_task_unittest.cc

Issue 2473553004: Request Picker task (Closed)
Patch Set: CR fixes per DougArnett Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/background/mark_attempt_completed_task.h" 5 #include "components/offline_pages/background/mark_attempt_completed_task.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 15 matching lines...) Expand all
26 MarkAttemptCompletedTaskTest(); 26 MarkAttemptCompletedTaskTest();
27 ~MarkAttemptCompletedTaskTest() override; 27 ~MarkAttemptCompletedTaskTest() override;
28 28
29 void PumpLoop(); 29 void PumpLoop();
30 30
31 void AddStartedItemToStore(RequestQueueStore* store); 31 void AddStartedItemToStore(RequestQueueStore* store);
32 32
33 void AddRequestDone(ItemActionStatus status); 33 void AddRequestDone(ItemActionStatus status);
34 34
35 void ChangeRequestsStateCallback( 35 void ChangeRequestsStateCallback(
36 std::unique_ptr<UpdateRequestsResult> result); 36 std::unique_ptr<QueueResults::UpdateRequestsResult> result);
37 37
38 UpdateRequestsResult* last_result() const { return result_.get(); } 38 QueueResults::UpdateRequestsResult* last_result() const {
39 return result_.get();
40 }
39 41
40 private: 42 private:
41 std::unique_ptr<UpdateRequestsResult> result_; 43 std::unique_ptr<QueueResults::UpdateRequestsResult> result_;
42 scoped_refptr<base::TestSimpleTaskRunner> task_runner_; 44 scoped_refptr<base::TestSimpleTaskRunner> task_runner_;
43 base::ThreadTaskRunnerHandle task_runner_handle_; 45 base::ThreadTaskRunnerHandle task_runner_handle_;
44 }; 46 };
45 47
46 MarkAttemptCompletedTaskTest::MarkAttemptCompletedTaskTest() 48 MarkAttemptCompletedTaskTest::MarkAttemptCompletedTaskTest()
47 : task_runner_(new base::TestSimpleTaskRunner), 49 : task_runner_(new base::TestSimpleTaskRunner),
48 task_runner_handle_(task_runner_) {} 50 task_runner_handle_(task_runner_) {}
49 51
50 MarkAttemptCompletedTaskTest::~MarkAttemptCompletedTaskTest() {} 52 MarkAttemptCompletedTaskTest::~MarkAttemptCompletedTaskTest() {}
51 53
(...skipping 11 matching lines...) Expand all
63 base::Bind(&MarkAttemptCompletedTaskTest::AddRequestDone, 65 base::Bind(&MarkAttemptCompletedTaskTest::AddRequestDone,
64 base::Unretained(this))); 66 base::Unretained(this)));
65 PumpLoop(); 67 PumpLoop();
66 } 68 }
67 69
68 void MarkAttemptCompletedTaskTest::AddRequestDone(ItemActionStatus status) { 70 void MarkAttemptCompletedTaskTest::AddRequestDone(ItemActionStatus status) {
69 ASSERT_EQ(ItemActionStatus::SUCCESS, status); 71 ASSERT_EQ(ItemActionStatus::SUCCESS, status);
70 } 72 }
71 73
72 void MarkAttemptCompletedTaskTest::ChangeRequestsStateCallback( 74 void MarkAttemptCompletedTaskTest::ChangeRequestsStateCallback(
73 std::unique_ptr<UpdateRequestsResult> result) { 75 std::unique_ptr<QueueResults::UpdateRequestsResult> result) {
74 result_ = std::move(result); 76 result_ = std::move(result);
75 } 77 }
76 78
77 TEST_F(MarkAttemptCompletedTaskTest, MarkAttemptCompletedWhenExists) { 79 TEST_F(MarkAttemptCompletedTaskTest, MarkAttemptCompletedWhenExists) {
78 RequestQueueInMemoryStore store; 80 RequestQueueInMemoryStore store;
79 AddStartedItemToStore(&store); 81 AddStartedItemToStore(&store);
80 82
81 MarkAttemptCompletedTask task( 83 MarkAttemptCompletedTask task(
82 &store, kRequestId1, 84 &store, kRequestId1,
83 base::Bind(&MarkAttemptCompletedTaskTest::ChangeRequestsStateCallback, 85 base::Bind(&MarkAttemptCompletedTaskTest::ChangeRequestsStateCallback,
(...skipping 25 matching lines...) Expand all
109 PumpLoop(); 111 PumpLoop();
110 ASSERT_TRUE(last_result()); 112 ASSERT_TRUE(last_result());
111 EXPECT_EQ(1UL, last_result()->item_statuses.size()); 113 EXPECT_EQ(1UL, last_result()->item_statuses.size());
112 EXPECT_EQ(kRequestId2, last_result()->item_statuses.at(0).first); 114 EXPECT_EQ(kRequestId2, last_result()->item_statuses.at(0).first);
113 EXPECT_EQ(ItemActionStatus::NOT_FOUND, 115 EXPECT_EQ(ItemActionStatus::NOT_FOUND,
114 last_result()->item_statuses.at(0).second); 116 last_result()->item_statuses.at(0).second);
115 EXPECT_EQ(0UL, last_result()->updated_items.size()); 117 EXPECT_EQ(0UL, last_result()->updated_items.size());
116 } 118 }
117 119
118 } // namespace offline_pages 120 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698