Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: components/offline_pages/background/mark_attempt_aborted_task_unittest.cc

Issue 2473553004: Request Picker task (Closed)
Patch Set: CR fixes per DougArnett Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/background/mark_attempt_aborted_task.h" 5 #include "components/offline_pages/background/mark_attempt_aborted_task.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/test/test_simple_task_runner.h" 10 #include "base/test/test_simple_task_runner.h"
(...skipping 15 matching lines...) Expand all
26 MarkAttemptAbortedTaskTest(); 26 MarkAttemptAbortedTaskTest();
27 ~MarkAttemptAbortedTaskTest() override; 27 ~MarkAttemptAbortedTaskTest() override;
28 28
29 void PumpLoop(); 29 void PumpLoop();
30 30
31 void AddItemToStore(RequestQueueStore* store); 31 void AddItemToStore(RequestQueueStore* store);
32 32
33 void AddRequestDone(ItemActionStatus status); 33 void AddRequestDone(ItemActionStatus status);
34 34
35 void ChangeRequestsStateCallback( 35 void ChangeRequestsStateCallback(
36 std::unique_ptr<UpdateRequestsResult> result); 36 std::unique_ptr<QueueResults::UpdateRequestsResult> result);
37 37
38 void ClearResults(); 38 void ClearResults();
39 39
40 UpdateRequestsResult* last_result() const { return result_.get(); } 40 QueueResults::UpdateRequestsResult* last_result() const {
41 return result_.get();
42 }
41 43
42 private: 44 private:
43 std::unique_ptr<UpdateRequestsResult> result_; 45 std::unique_ptr<QueueResults::UpdateRequestsResult> result_;
44 scoped_refptr<base::TestSimpleTaskRunner> task_runner_; 46 scoped_refptr<base::TestSimpleTaskRunner> task_runner_;
45 base::ThreadTaskRunnerHandle task_runner_handle_; 47 base::ThreadTaskRunnerHandle task_runner_handle_;
46 }; 48 };
47 49
48 MarkAttemptAbortedTaskTest::MarkAttemptAbortedTaskTest() 50 MarkAttemptAbortedTaskTest::MarkAttemptAbortedTaskTest()
49 : task_runner_(new base::TestSimpleTaskRunner), 51 : task_runner_(new base::TestSimpleTaskRunner),
50 task_runner_handle_(task_runner_) {} 52 task_runner_handle_(task_runner_) {}
51 53
52 MarkAttemptAbortedTaskTest::~MarkAttemptAbortedTaskTest() {} 54 MarkAttemptAbortedTaskTest::~MarkAttemptAbortedTaskTest() {}
53 55
54 void MarkAttemptAbortedTaskTest::PumpLoop() { 56 void MarkAttemptAbortedTaskTest::PumpLoop() {
55 task_runner_->RunUntilIdle(); 57 task_runner_->RunUntilIdle();
56 } 58 }
57 59
58 void MarkAttemptAbortedTaskTest::AddItemToStore(RequestQueueStore* store) { 60 void MarkAttemptAbortedTaskTest::AddItemToStore(RequestQueueStore* store) {
59 base::Time creation_time = base::Time::Now(); 61 base::Time creation_time = base::Time::Now();
60 SavePageRequest request_1(kRequestId1, kUrl1, kClientId1, creation_time, 62 SavePageRequest request_1(kRequestId1, kUrl1, kClientId1, creation_time,
61 true); 63 true);
62 store->AddRequest(request_1, 64 store->AddRequest(request_1,
63 base::Bind(&MarkAttemptAbortedTaskTest::AddRequestDone, 65 base::Bind(&MarkAttemptAbortedTaskTest::AddRequestDone,
64 base::Unretained(this))); 66 base::Unretained(this)));
65 PumpLoop(); 67 PumpLoop();
66 } 68 }
67 69
68 void MarkAttemptAbortedTaskTest::AddRequestDone(ItemActionStatus status) { 70 void MarkAttemptAbortedTaskTest::AddRequestDone(ItemActionStatus status) {
69 ASSERT_EQ(ItemActionStatus::SUCCESS, status); 71 ASSERT_EQ(ItemActionStatus::SUCCESS, status);
70 } 72 }
71 73
72 void MarkAttemptAbortedTaskTest::ChangeRequestsStateCallback( 74 void MarkAttemptAbortedTaskTest::ChangeRequestsStateCallback(
73 std::unique_ptr<UpdateRequestsResult> result) { 75 std::unique_ptr<QueueResults::UpdateRequestsResult> result) {
74 result_ = std::move(result); 76 result_ = std::move(result);
75 } 77 }
76 78
77 void MarkAttemptAbortedTaskTest::ClearResults() { 79 void MarkAttemptAbortedTaskTest::ClearResults() {
78 result_.reset(nullptr); 80 result_.reset(nullptr);
79 } 81 }
80 82
81 TEST_F(MarkAttemptAbortedTaskTest, MarkAttemptAbortedWhenStoreEmpty) { 83 TEST_F(MarkAttemptAbortedTaskTest, MarkAttemptAbortedWhenStoreEmpty) {
82 RequestQueueInMemoryStore store; 84 RequestQueueInMemoryStore store;
83 MarkAttemptAbortedTask task( 85 MarkAttemptAbortedTask task(
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 PumpLoop(); 137 PumpLoop();
136 ASSERT_TRUE(last_result()); 138 ASSERT_TRUE(last_result());
137 EXPECT_EQ(1UL, last_result()->item_statuses.size()); 139 EXPECT_EQ(1UL, last_result()->item_statuses.size());
138 EXPECT_EQ(kRequestId2, last_result()->item_statuses.at(0).first); 140 EXPECT_EQ(kRequestId2, last_result()->item_statuses.at(0).first);
139 EXPECT_EQ(ItemActionStatus::NOT_FOUND, 141 EXPECT_EQ(ItemActionStatus::NOT_FOUND,
140 last_result()->item_statuses.at(0).second); 142 last_result()->item_statuses.at(0).second);
141 EXPECT_EQ(0UL, last_result()->updated_items.size()); 143 EXPECT_EQ(0UL, last_result()->updated_items.size());
142 } 144 }
143 145
144 } // namespace offline_pages 146 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698