Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: components/offline_pages/background/change_requests_state_task_unittest.cc

Issue 2473553004: Request Picker task (Closed)
Patch Set: CR fixes per DougArnett Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/background/change_requests_state_task.h" 5 #include "components/offline_pages/background/change_requests_state_task.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/test/test_simple_task_runner.h" 10 #include "base/test/test_simple_task_runner.h"
(...skipping 17 matching lines...) Expand all
28 ChangeRequestsStateTaskTest(); 28 ChangeRequestsStateTaskTest();
29 ~ChangeRequestsStateTaskTest() override; 29 ~ChangeRequestsStateTaskTest() override;
30 30
31 void PumpLoop(); 31 void PumpLoop();
32 32
33 void SetUpStore(RequestQueueStore* store); 33 void SetUpStore(RequestQueueStore* store);
34 34
35 void AddRequestDone(ItemActionStatus status); 35 void AddRequestDone(ItemActionStatus status);
36 36
37 void ChangeRequestsStateCallback( 37 void ChangeRequestsStateCallback(
38 std::unique_ptr<UpdateRequestsResult> result); 38 std::unique_ptr<QueueResults::UpdateRequestsResult> result);
39 39
40 UpdateRequestsResult* last_result() const { return result_.get(); } 40 QueueResults::UpdateRequestsResult* last_result() const {
41 return result_.get();
42 }
41 43
42 private: 44 private:
43 std::unique_ptr<UpdateRequestsResult> result_; 45 std::unique_ptr<QueueResults::UpdateRequestsResult> result_;
44 scoped_refptr<base::TestSimpleTaskRunner> task_runner_; 46 scoped_refptr<base::TestSimpleTaskRunner> task_runner_;
45 base::ThreadTaskRunnerHandle task_runner_handle_; 47 base::ThreadTaskRunnerHandle task_runner_handle_;
46 }; 48 };
47 49
48 ChangeRequestsStateTaskTest::ChangeRequestsStateTaskTest() 50 ChangeRequestsStateTaskTest::ChangeRequestsStateTaskTest()
49 : task_runner_(new base::TestSimpleTaskRunner), 51 : task_runner_(new base::TestSimpleTaskRunner),
50 task_runner_handle_(task_runner_) {} 52 task_runner_handle_(task_runner_) {}
51 53
52 ChangeRequestsStateTaskTest::~ChangeRequestsStateTaskTest() {} 54 ChangeRequestsStateTaskTest::~ChangeRequestsStateTaskTest() {}
53 55
(...skipping 14 matching lines...) Expand all
68 base::Bind(&ChangeRequestsStateTaskTest::AddRequestDone, 70 base::Bind(&ChangeRequestsStateTaskTest::AddRequestDone,
69 base::Unretained(this))); 71 base::Unretained(this)));
70 PumpLoop(); 72 PumpLoop();
71 } 73 }
72 74
73 void ChangeRequestsStateTaskTest::AddRequestDone(ItemActionStatus status) { 75 void ChangeRequestsStateTaskTest::AddRequestDone(ItemActionStatus status) {
74 ASSERT_EQ(ItemActionStatus::SUCCESS, status); 76 ASSERT_EQ(ItemActionStatus::SUCCESS, status);
75 } 77 }
76 78
77 void ChangeRequestsStateTaskTest::ChangeRequestsStateCallback( 79 void ChangeRequestsStateTaskTest::ChangeRequestsStateCallback(
78 std::unique_ptr<UpdateRequestsResult> result) { 80 std::unique_ptr<QueueResults::UpdateRequestsResult> result) {
79 result_ = std::move(result); 81 result_ = std::move(result);
80 } 82 }
81 83
82 TEST_F(ChangeRequestsStateTaskTest, UpdateWhenStoreEmpty) { 84 TEST_F(ChangeRequestsStateTaskTest, UpdateWhenStoreEmpty) {
83 RequestQueueInMemoryStore store; 85 RequestQueueInMemoryStore store;
84 std::vector<int64_t> request_ids{kRequestId1}; 86 std::vector<int64_t> request_ids{kRequestId1};
85 ChangeRequestsStateTask task( 87 ChangeRequestsStateTask task(
86 &store, request_ids, SavePageRequest::RequestState::PAUSED, 88 &store, request_ids, SavePageRequest::RequestState::PAUSED,
87 base::Bind(&ChangeRequestsStateTaskTest::ChangeRequestsStateCallback, 89 base::Bind(&ChangeRequestsStateTaskTest::ChangeRequestsStateCallback,
88 base::Unretained(this))); 90 base::Unretained(this)));
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 last_result()->item_statuses.at(0).second); 176 last_result()->item_statuses.at(0).second);
175 EXPECT_EQ(kRequestId3, last_result()->item_statuses.at(1).first); 177 EXPECT_EQ(kRequestId3, last_result()->item_statuses.at(1).first);
176 EXPECT_EQ(ItemActionStatus::NOT_FOUND, 178 EXPECT_EQ(ItemActionStatus::NOT_FOUND,
177 last_result()->item_statuses.at(1).second); 179 last_result()->item_statuses.at(1).second);
178 EXPECT_EQ(1UL, last_result()->updated_items.size()); 180 EXPECT_EQ(1UL, last_result()->updated_items.size());
179 EXPECT_EQ(SavePageRequest::RequestState::PAUSED, 181 EXPECT_EQ(SavePageRequest::RequestState::PAUSED,
180 last_result()->updated_items.at(0).request_state()); 182 last_result()->updated_items.at(0).request_state());
181 } 183 }
182 184
183 } // namespace offline_pages 185 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698