Request Picker task

components/offline_pages/background/pick_request_task_factory.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_PICK_REQUEST_TASK_FACTORY_H_
+#define COMPONENTS_OFFLINE_PAGES_BACKGROUND_PICK_REQUEST_TASK_FACTORY_H_
+
+#include "components/offline_pages/background/device_conditions.h"

[fgorski, 2016/11/09 17:58:07]

nit: can this be forward declared?

[Pete Williamson, 2016/11/09 23:53:56]

Done.

+#include "components/offline_pages/background/pick_request_task.h"

[fgorski, 2016/11/09 17:58:07]

nit: can this be forward declared?

[Pete Williamson, 2016/11/09 23:53:56]

Nope, needed for the callback types.

+#include "components/offline_pages/background/request_coordinator.h"

[fgorski, 2016/11/09 17:58:07]

is this needed?

[Pete Williamson, 2016/11/09 23:53:56]

Removed.  (and then added in a few places that were depending on it, and had
been getting it from here)

+
+namespace offline_pages {
+
+class OfflinerPolicy;
+class RequestCoordinatorEventLogger;
+class RequestNotifier;
+class RequestQueue;

[fgorski, 2016/11/09 17:58:07]

should this be store?

[Pete Williamson, 2016/11/09 23:53:56]

Done.

+
+class PickRequestTaskFactory {
+ public:
+  PickRequestTaskFactory(OfflinerPolicy* policy,
+                         RequestNotifier* notifier,
+                         RequestCoordinatorEventLogger* event_logger);
+
+  ~PickRequestTaskFactory();
+
+  std::unique_ptr<PickRequestTask> CreatePickerTask(
+      RequestQueueStore* store,
+      const PickRequestTask::RequestPickedCallback& picked_callback,
+      const PickRequestTask::RequestNotPickedCallback& not_picked_callback,
+      DeviceConditions& conditions,
+      std::set<int64_t>& disabled_requests);

[fgorski, 2016/11/09 17:58:07]

missing includes for set and int64_t

[Pete Williamson, 2016/11/09 23:53:55]

Done.

+
+ private:
+  // Unowned pointer to the Policy
+  OfflinerPolicy* policy_;
+  // Unowned pointer to the notifier
+  RequestNotifier* notifier_;
+  // Unowned pointer to the EventLogger
+  RequestCoordinatorEventLogger* event_logger_;
+};
+
+}  // namespace offline_pages
+
+#endif  // COMPONENTS_OFFLINE_PAGES_BACKGROUND_PICK_REQUEST_TASK_FACTORY_H_