Request Picker task

chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_OFFLINE_OFFLINE_INTERNALS_UI_MESSAGE_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_OFFLINE_OFFLINE_INTERNALS_UI_MESSAGE_HANDLER_H_
 
 #include "base/memory/weak_ptr.h"
 #include "base/values.h"
 #include "components/offline_pages/background/request_coordinator.h"
+#include "components/offline_pages/background/request_queue_results.h"
 #include "components/offline_pages/background/save_page_request.h"
 #include "components/offline_pages/offline_page_model.h"
 #include "components/offline_pages/offline_store_types.h"
 #include "content/public/browser/web_ui_message_handler.h"
 
 namespace offline_internals {
 
 // Class acting as a controller of the chrome://offline-internals WebUI.
 class OfflineInternalsUIMessageHandler : public content::WebUIMessageHandler {
  public:
@@ skipping 35 matching lines @@
   void HandleGetNetworkStatus(const base::ListValue* args);
 
   // Callback for async GetAllPages calls.
   void HandleStoredPagesCallback(
       std::string callback_id,
       const offline_pages::MultipleOfflinePageItemResult& pages);
 
   // Callback for async GetRequests calls.
   void HandleRequestQueueCallback(
       std::string callback_id,
-      offline_pages::RequestQueue::GetRequestsResult result,

[Evan Stade, 2016/11/09 00:43:03]

wait a second, enum class lets you forward declare this.

namespace offline_pages {
enum class GetRequestsResult;
}

at the top of this file instead of the header include.

[Pete Williamson, 2016/11/09 00:55:29]

Done.

+      offline_pages::GetRequestsResult result,
       std::vector<std::unique_ptr<offline_pages::SavePageRequest>> requests);
 
   // Callback for DeletePage/DeleteAllPages calls.
   void HandleDeletedPagesCallback(std::string callback_id,
                                   const offline_pages::DeletePageResult result);
 
   // Callback for DeleteRequest/DeleteAllRequests calls.
   void HandleDeletedRequestsCallback(
       std::string callback_id,
       const offline_pages::MultipleItemStatuses& results);
@@ skipping 17 matching lines @@
 
   // Factory for creating references in callbacks.
   base::WeakPtrFactory<OfflineInternalsUIMessageHandler> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(OfflineInternalsUIMessageHandler);
 };
 
 }  // namespace offline_internals
 
 #endif // CHROME_BROWSER_UI_WEBUI_OFFLINE_OFFLINE_INTERNALS_UI_MESSAGE_HANDLER_H_