Request Picker task

chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.h"
 
 #include <stdint.h>
 #include <stdlib.h>
 #include <vector>
 
@@ skipping 133 matching lines @@
     offline_page->SetDouble("creationTime", page.creation_time.ToJsTime());
     offline_page->SetDouble("lastAccessTime", page.last_access_time.ToJsTime());
     offline_page->SetInteger("accessCount", page.access_count);
     offline_page->SetString("isExpired", page.IsExpired() ? "Yes" : "No");
   }
   ResolveJavascriptCallback(base::StringValue(callback_id), results);
 }
 
 void OfflineInternalsUIMessageHandler::HandleRequestQueueCallback(
     std::string callback_id,
-    offline_pages::RequestQueue::GetRequestsResult result,
+    offline_pages::QueueResults::GetRequestsResult result,
     std::vector<std::unique_ptr<offline_pages::SavePageRequest>> requests) {
   base::ListValue save_page_requests;
-  if (result == offline_pages::RequestQueue::GetRequestsResult::SUCCESS) {
+  if (result == offline_pages::QueueResults::GetRequestsResult::SUCCESS) {

[Evan Stade, 2016/11/08 23:13:36]

doesn't seem this was updated?

[Pete Williamson, 2016/11/09 00:24:48]

Ah, I did my grep in the directory where most of the files were, but not this
one.  I went back and double checked all files in the changelist.

     for (const auto& request : requests) {
       base::DictionaryValue* save_page_request = new base::DictionaryValue();
       save_page_requests.Append(save_page_request);
       save_page_request->SetString("onlineUrl", request->url().spec());
       save_page_request->SetDouble("creationTime",
                                    request->creation_time().ToJsTime());
       save_page_request->SetString("status", GetStringFromSavePageStatus());
       save_page_request->SetString("namespace",
                                    request->client_id().name_space);
       save_page_request->SetDouble("lastAttempt",
@@ skipping 171 matching lines @@
 
   // Get the offline page model associated with this web ui.
   Profile* profile = Profile::FromWebUI(web_ui());
   offline_page_model_ =
       offline_pages::OfflinePageModelFactory::GetForBrowserContext(profile);
   request_coordinator_ =
       offline_pages::RequestCoordinatorFactory::GetForBrowserContext(profile);
 }
 
 }  // namespace offline_internals