blimp/client/core/settings/user_agent.h - Issue 2473543002: Set the user agent for 0.6

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/client/core/settings/user_agent.h

Issue 2473543002: Set the user agent for 0.6 (Closed)

Patch Set: remove settings_feature from BlimpClientSession Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef BLIMP_CLIENT_APP_USER_AGENT_H_	5 #ifndef BLIMP_CLIENT_CORE_SETTINGS_USER_AGENT_H_

6 #define BLIMP_CLIENT_APP_USER_AGENT_H_	6 #define BLIMP_CLIENT_CORE_SETTINGS_USER_AGENT_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 namespace blimp {	10 namespace blimp {
	Khushal 2016/11/02 01:32:49 This should be blimp::client namespace. This should be blimp::client namespace. Menglin 2016/11/02 16:34:57 Done. Show quoted text On 2016/11/02 01:32:49, Khushal wrote: > This should be blimp::client namespace. Done.
11	11

12 /**	12 /**

13 * Builds a User-agent compatible string that describes the OS and CPU type.	13 * Builds a User-agent compatible string that describes the OS and CPU type.

14 * e.g. Linux; Android 5.1.1; Nexus 6 Build/LMY49C	14 * e.g. Linux; Android 5.1.1; Nexus 6 Build/LMY49C

15 */	15 */

16 std::string GetOSVersionInfoForUserAgent();	16 std::string GetOSVersionInfoForUserAgent();

17	17

18 } // namespace blimp	18 } // namespace blimp

19	19

20 #endif // BLIMP_CLIENT_APP_USER_AGENT_H_	20 #endif // BLIMP_CLIENT_CORE_SETTINGS_USER_AGENT_H_

OLD	NEW