Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2473513002: Take more current safe_math_impl.h from upstream. (Closed)

Created:
4 years, 1 month ago by Tom Sepez
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang, jschuh
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Take more current safe_math_impl.h from upstream. Corresponds to version dfd77a987650965071d0fddfbe0b806ce62ba337. Major change is to handle div by 0 without exceptions. Safe shift is not yet present. TBR=thestig@chromium.org TBR=jschuh@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/66bd67023f747c489d7144aaf4ca6222c686cd26

Patch Set 1 #

Patch Set 2 : Guard macros #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -35 lines) Patch
M third_party/base/numerics/safe_math_impl.h View 1 14 chunks +61 lines, -35 lines 0 comments Download

Messages

Total messages: 12 (9 generated)
Tom Sepez
TBR, because we already discussed this upstream.
4 years, 1 month ago (2016-11-02 20:26:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473513002/20001
4 years, 1 month ago (2016-11-02 20:26:41 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 20:26:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/66bd67023f747c489d7144aaf4ca6222c686...

Powered by Google App Engine
This is Rietveld 408576698