Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2473493002: [Autofill] Credit card signin promo: do not require a local suggestion first. (Closed)

Created:
4 years, 1 month ago by Mathieu
Modified:
4 years, 1 month ago
Reviewers:
sebsg
CC:
chromium-reviews, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Credit card signin promo: do not require a local suggestion Previously was requiring a local credit card suggestions before showing the promo. Now it can show when there are no credit card suggestions. BUG=626442 TEST=AutofillManager,AutofillExternalDelegate Committed: https://crrev.com/a64f430204b0c25369b2b4130dfa4b838dbf6e16 Cr-Commit-Position: refs/heads/master@{#429413}

Patch Set 1 #

Total comments: 6

Patch Set 2 : added test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -25 lines) Patch
M components/autofill/core/browser/autofill_external_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_external_delegate.cc View 1 5 chunks +26 lines, -19 lines 0 comments Download
M components/autofill/core/browser/autofill_external_delegate_unittest.cc View 2 chunks +36 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 2 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Mathieu
Mr. Seb, PTAL
4 years, 1 month ago (2016-11-01 21:11:55 UTC) #7
sebsg
LGTM with optional nits. https://codereview.chromium.org/2473493002/diff/1/components/autofill/core/browser/autofill_external_delegate.cc File components/autofill/core/browser/autofill_external_delegate.cc (right): https://codereview.chromium.org/2473493002/diff/1/components/autofill/core/browser/autofill_external_delegate.cc#newcode79 components/autofill/core/browser/autofill_external_delegate.cc:79: if (suggestions.size()) { I think ...
4 years, 1 month ago (2016-11-01 21:31:15 UTC) #8
Mathieu
Thanks https://codereview.chromium.org/2473493002/diff/1/components/autofill/core/browser/autofill_external_delegate.cc File components/autofill/core/browser/autofill_external_delegate.cc (right): https://codereview.chromium.org/2473493002/diff/1/components/autofill/core/browser/autofill_external_delegate.cc#newcode79 components/autofill/core/browser/autofill_external_delegate.cc:79: if (suggestions.size()) { On 2016/11/01 21:31:15, sebsg wrote: ...
4 years, 1 month ago (2016-11-02 21:01:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473493002/20001
4 years, 1 month ago (2016-11-02 21:02:06 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-02 21:56:03 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 21:59:14 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a64f430204b0c25369b2b4130dfa4b838dbf6e16
Cr-Commit-Position: refs/heads/master@{#429413}

Powered by Google App Engine
This is Rietveld 408576698