[Autofill] Credit card signin promo: do not require a local suggestion first.

[Autofill] Credit card signin promo: do not require a local suggestion

Previously was requiring a local credit card suggestions before showing the
promo. Now it can show when there are no credit card suggestions.

BUG=626442
TEST=AutofillManager,AutofillExternalDelegate

Committed: https://crrev.com/a64f430204b0c25369b2b4130dfa4b838dbf6e16
Cr-Commit-Position: refs/heads/master@{#429413}

[Mathieu, 2016-11-01 20:18:51]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[Mathieu, 2016-11-01 20:19:17]

Description was changed from

==========
[Autofill] Credit card signin promo: do not require a local suggestion first.

Previously was requiring a local credit card suggestions before showing the
promo. Now it can show when there are no credit card suggestions.

BUG=626442
TEST=AutofillManager,AutofillExternalDelegate
==========

to

==========
[Autofill] Credit card signin promo: do not require a local suggestion

Previously was requiring a local credit card suggestions before showing the
promo. Now it can show when there are no credit card suggestions.

BUG=626442
TEST=AutofillManager,AutofillExternalDelegate
==========

[Mathieu, 2016-11-01 20:19:17]

mathp@chromium.org changed reviewers:
+ sebsg@chromium.org

[commit-bot: I haz the power, 2016-11-01 20:19:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 21:11:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 21:11:21]

Dry run: This issue passed the CQ dry run.

[Mathieu, 2016-11-01 21:11:55]

Mr. Seb, PTAL

[sebsg, 2016-11-01 21:31:15]

LGTM with optional nits.

https://codereview.chromium.org/2473493002/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_external_delegate.cc (right):

https://codereview.chromium.org/2473493002/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_external_delegate.cc:79: if
(suggestions.size()) {
I think (!suggestions.empty()) might be more clear?

https://codereview.chromium.org/2473493002/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_external_delegate.cc:134: if
(suggestions.size() &&
ditto

https://codereview.chromium.org/2473493002/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_manager.cc (right):

https://codereview.chromium.org/2473493002/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_manager.cc:612: if
(suggestions.empty() && !ShouldShowCreditCardSigninPromo(form, field) &&
Do you think you could add a test for that?

[Mathieu, 2016-11-02 21:01:04]

Thanks

https://codereview.chromium.org/2473493002/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_external_delegate.cc (right):

https://codereview.chromium.org/2473493002/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_external_delegate.cc:79: if
(suggestions.size()) {
On 2016/11/01 21:31:15, sebsg wrote:
> I think (!suggestions.empty()) might be more clear?

Done.

https://codereview.chromium.org/2473493002/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_external_delegate.cc:134: if
(suggestions.size() &&
On 2016/11/01 21:31:15, sebsg wrote:
> ditto

Done.

https://codereview.chromium.org/2473493002/diff/1/components/autofill/core/br...
File components/autofill/core/browser/autofill_manager.cc (right):

https://codereview.chromium.org/2473493002/diff/1/components/autofill/core/br...
components/autofill/core/browser/autofill_manager.cc:612: if
(suggestions.empty() && !ShouldShowCreditCardSigninPromo(form, field) &&
On 2016/11/01 21:31:15, sebsg wrote:
> Do you think you could add a test for that?

Certainly can!

[Mathieu, 2016-11-02 21:01:07]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2016-11-02 21:01:08]

The patchset sent to the CQ was uploaded after l-g-t-m from sebsg@chromium.org
Link to the patchset: https://codereview.chromium.org/2473493002/#ps20001
(title: "added test")

[commit-bot: I haz the power, 2016-11-02 21:02:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 21:56:02]

Description was changed from

==========
[Autofill] Credit card signin promo: do not require a local suggestion

Previously was requiring a local credit card suggestions before showing the
promo. Now it can show when there are no credit card suggestions.

BUG=626442
TEST=AutofillManager,AutofillExternalDelegate
==========

to

==========
[Autofill] Credit card signin promo: do not require a local suggestion

Previously was requiring a local credit card suggestions before showing the
promo. Now it can show when there are no credit card suggestions.

BUG=626442
TEST=AutofillManager,AutofillExternalDelegate
==========

[commit-bot: I haz the power, 2016-11-02 21:56:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-02 21:59:13]

Description was changed from

==========
[Autofill] Credit card signin promo: do not require a local suggestion

Previously was requiring a local credit card suggestions before showing the
promo. Now it can show when there are no credit card suggestions.

BUG=626442
TEST=AutofillManager,AutofillExternalDelegate
==========

to

==========
[Autofill] Credit card signin promo: do not require a local suggestion

Previously was requiring a local credit card suggestions before showing the
promo. Now it can show when there are no credit card suggestions.

BUG=626442
TEST=AutofillManager,AutofillExternalDelegate

Committed: https://crrev.com/a64f430204b0c25369b2b4130dfa4b838dbf6e16
Cr-Commit-Position: refs/heads/master@{#429413}
==========

[commit-bot: I haz the power, 2016-11-02 21:59:14]

Patchset 2 (id:??) landed as
https://crrev.com/a64f430204b0c25369b2b4130dfa4b838dbf6e16
Cr-Commit-Position: refs/heads/master@{#429413}