Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Issue 2473483013: [ash-md] Enhanced LayerAnimator to allow animations to be aborted/started in OnLayerAnimationStarte… (Closed)

Created:
4 years, 1 month ago by bruthig
Modified:
4 years, 1 month ago
Reviewers:
ajuma
CC:
chromium-reviews, jbauman+watch_chromium.org, kalyank, danakj+watch_chromium.org, Ian Vollick, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Enhanced LayerAnimator to allow animations to be aborted/started in OnLayerAnimationStarted() events. The InkDrop requires for animations to be aborted and started in an OnLayerAnimationStarted() event which is currently not possible. This CL fixes that. BUG=649734 TEST=LayerAnimatorTest.SequencesAreRemovedFromQueueBeforeBeingNotifiedOfStarted Committed: https://crrev.com/4a12c2b60910eed6d10964007c39145e362dae15 Cr-Commit-Position: refs/heads/master@{#430078}

Patch Set 1 #

Patch Set 2 : Added test to expose bug and fixed bug. #

Total comments: 6

Patch Set 3 : Addresse review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -24 lines) Patch
M ui/compositor/layer_animation_observer.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/compositor/layer_animation_sequence.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M ui/compositor/layer_animator.cc View 1 1 chunk +7 lines, -5 lines 0 comments Download
M ui/compositor/layer_animator_unittest.cc View 1 2 8 chunks +168 lines, -17 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
bruthig
ajuma@, can you PTAL?
4 years, 1 month ago (2016-11-04 20:21:10 UTC) #6
ajuma
lgtm https://codereview.chromium.org/2473483013/diff/20001/ui/compositor/layer_animator_unittest.cc File ui/compositor/layer_animator_unittest.cc (right): https://codereview.chromium.org/2473483013/diff/20001/ui/compositor/layer_animator_unittest.cc#newcode274 ui/compositor/layer_animator_unittest.cc:274: CHECK_LE(started_count_, attached_sequence_count_); Given that this is happening inside ...
4 years, 1 month ago (2016-11-04 22:49:40 UTC) #7
bruthig
ajuma@, take a look if you wish but not requested. https://codereview.chromium.org/2473483013/diff/20001/ui/compositor/layer_animator_unittest.cc File ui/compositor/layer_animator_unittest.cc (right): https://codereview.chromium.org/2473483013/diff/20001/ui/compositor/layer_animator_unittest.cc#newcode274 ...
4 years, 1 month ago (2016-11-04 22:58:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473483013/40001
4 years, 1 month ago (2016-11-04 22:59:00 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-05 00:20:03 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-05 00:22:49 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4a12c2b60910eed6d10964007c39145e362dae15
Cr-Commit-Position: refs/heads/master@{#430078}

Powered by Google App Engine
This is Rietveld 408576698