[ash-md] Enhanced LayerAnimator to allow animations to be aborted/started in OnLayerAnimationStarte…

[ash-md] Enhanced LayerAnimator to allow animations to be aborted/started in OnLayerAnimationStarted() events.

The InkDrop requires for animations to be aborted and started in an
OnLayerAnimationStarted() event which is currently not possible. This
CL fixes that.

BUG=649734
TEST=LayerAnimatorTest.SequencesAreRemovedFromQueueBeforeBeingNotifiedOfStarted

Committed: https://crrev.com/4a12c2b60910eed6d10964007c39145e362dae15
Cr-Commit-Position: refs/heads/master@{#430078}

[bruthig, 2016-11-04 18:53:01]

Description was changed from

==========
[ash-md] Enhanced LayerAnimator to allow animations to be aborted/started in
OnLayerAnimationStarted() events.

The InkDrop requires for animations to be aborted and started in an
OnLayerAnimationStarted() event which is currently not possible. This
CL fixes that.

BUG=649734
TEST=WIP
==========

to

==========
[ash-md] Enhanced LayerAnimator to allow animations to be aborted/started in
OnLayerAnimationStarted() events.

[WIP] This is a work in progress until I can write a test to expose the problem.

The InkDrop requires for animations to be aborted and started in an
OnLayerAnimationStarted() event which is currently not possible. This
CL fixes that.

BUG=649734
TEST=WIP
==========

[bruthig, 2016-11-04 20:19:30]

The CQ bit was checked by bruthig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 20:20:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bruthig, 2016-11-04 20:20:53]

Description was changed from

==========
[ash-md] Enhanced LayerAnimator to allow animations to be aborted/started in
OnLayerAnimationStarted() events.

[WIP] This is a work in progress until I can write a test to expose the problem.

The InkDrop requires for animations to be aborted and started in an
OnLayerAnimationStarted() event which is currently not possible. This
CL fixes that.

BUG=649734
TEST=WIP
==========

to

==========
[ash-md] Enhanced LayerAnimator to allow animations to be aborted/started in
OnLayerAnimationStarted() events.

The InkDrop requires for animations to be aborted and started in an
OnLayerAnimationStarted() event which is currently not possible. This
CL fixes that.

BUG=649734
TEST=LayerAnimatorTest.SequencesAreRemovedFromQueueBeforeBeingNotifiedOfStarted
==========

[bruthig, 2016-11-04 20:21:09]

bruthig@chromium.org changed reviewers:
+ ajuma@chromium.org

[bruthig, 2016-11-04 20:21:10]

ajuma@, can you PTAL?

[ajuma, 2016-11-04 22:49:40]

lgtm

https://codereview.chromium.org/2473483013/diff/20001/ui/compositor/layer_ani...
File ui/compositor/layer_animator_unittest.cc (right):

https://codereview.chromium.org/2473483013/diff/20001/ui/compositor/layer_ani...
ui/compositor/layer_animator_unittest.cc:274: CHECK_LE(started_count_,
attached_sequence_count_);
Given that this is happening inside a test, should these be EXPECTs rather than
CHECKs?

https://codereview.chromium.org/2473483013/diff/20001/ui/compositor/layer_ani...
ui/compositor/layer_animator_unittest.cc:331: // Observer to delegate calls to.
nit: "the delegate"

https://codereview.chromium.org/2473483013/diff/20001/ui/compositor/layer_ani...
ui/compositor/layer_animator_unittest.cc:2562: animator->Step(start_time +
sequence_duration * 3);
Please add an EXPECT_FALSE(animator->is_animating()) here.

[bruthig, 2016-11-04 22:58:20]

ajuma@, take a look if you wish but not requested.

https://codereview.chromium.org/2473483013/diff/20001/ui/compositor/layer_ani...
File ui/compositor/layer_animator_unittest.cc (right):

https://codereview.chromium.org/2473483013/diff/20001/ui/compositor/layer_ani...
ui/compositor/layer_animator_unittest.cc:274: CHECK_LE(started_count_,
attached_sequence_count_);
On 2016/11/04 22:49:40, ajuma wrote:
> Given that this is happening inside a test, should these be EXPECTs rather
than
> CHECKs?

Done.

https://codereview.chromium.org/2473483013/diff/20001/ui/compositor/layer_ani...
ui/compositor/layer_animator_unittest.cc:331: // Observer to delegate calls to.
On 2016/11/04 22:49:40, ajuma wrote:
> nit: "the delegate"

Not exactly sure what you are suggesting.  I've updated it to hopefully be more
clear.

https://codereview.chromium.org/2473483013/diff/20001/ui/compositor/layer_ani...
ui/compositor/layer_animator_unittest.cc:2562: animator->Step(start_time +
sequence_duration * 3);
On 2016/11/04 22:49:40, ajuma wrote:
> Please add an EXPECT_FALSE(animator->is_animating()) here.

Done.

[bruthig, 2016-11-04 22:58:23]

The CQ bit was checked by bruthig@chromium.org

[bruthig, 2016-11-04 22:58:24]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/2473483013/#ps40001
(title: "Addresse review comments.")

[commit-bot: I haz the power, 2016-11-04 22:59:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-05 00:20:02]

Description was changed from

==========
[ash-md] Enhanced LayerAnimator to allow animations to be aborted/started in
OnLayerAnimationStarted() events.

The InkDrop requires for animations to be aborted and started in an
OnLayerAnimationStarted() event which is currently not possible. This
CL fixes that.

BUG=649734
TEST=LayerAnimatorTest.SequencesAreRemovedFromQueueBeforeBeingNotifiedOfStarted
==========

to

==========
[ash-md] Enhanced LayerAnimator to allow animations to be aborted/started in
OnLayerAnimationStarted() events.

The InkDrop requires for animations to be aborted and started in an
OnLayerAnimationStarted() event which is currently not possible. This
CL fixes that.

BUG=649734
TEST=LayerAnimatorTest.SequencesAreRemovedFromQueueBeforeBeingNotifiedOfStarted
==========

[commit-bot: I haz the power, 2016-11-05 00:20:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-05 00:22:48]

Description was changed from

==========
[ash-md] Enhanced LayerAnimator to allow animations to be aborted/started in
OnLayerAnimationStarted() events.

The InkDrop requires for animations to be aborted and started in an
OnLayerAnimationStarted() event which is currently not possible. This
CL fixes that.

BUG=649734
TEST=LayerAnimatorTest.SequencesAreRemovedFromQueueBeforeBeingNotifiedOfStarted
==========

to

==========
[ash-md] Enhanced LayerAnimator to allow animations to be aborted/started in
OnLayerAnimationStarted() events.

The InkDrop requires for animations to be aborted and started in an
OnLayerAnimationStarted() event which is currently not possible. This
CL fixes that.

BUG=649734
TEST=LayerAnimatorTest.SequencesAreRemovedFromQueueBeforeBeingNotifiedOfStarted

Committed: https://crrev.com/4a12c2b60910eed6d10964007c39145e362dae15
Cr-Commit-Position: refs/heads/master@{#430078}
==========

[commit-bot: I haz the power, 2016-11-05 00:22:49]

Patchset 3 (id:??) landed as
https://crrev.com/4a12c2b60910eed6d10964007c39145e362dae15
Cr-Commit-Position: refs/heads/master@{#430078}