Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp

Issue 2473483012: Move content/child/background_sync to Blink. (Closed)
Patch Set: Fix nits Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp
diff --git a/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp b/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp
index c66fedb771f6193ac10c1e0ba8e5d9fb6c5fc8e8..3920c3aa23f9cc63b39a32a8b3c36f3510c38c6c 100644
--- a/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp
+++ b/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp
@@ -24,15 +24,13 @@ SyncRegistrationCallbacks::SyncRegistrationCallbacks(
SyncRegistrationCallbacks::~SyncRegistrationCallbacks() {}
void SyncRegistrationCallbacks::onSuccess(
- std::unique_ptr<WebSyncRegistration> webSyncRegistration) {
+ mojom::blink::SyncRegistrationPtr syncRegistration) {
if (!m_resolver->getExecutionContext() ||
m_resolver->getExecutionContext()->activeDOMObjectsAreStopped()) {
return;
}
- std::unique_ptr<WebSyncRegistration> registration =
- wrapUnique(webSyncRegistration.release());
- if (!registration) {
+ if (!syncRegistration) {
m_resolver->resolve(v8::Null(m_resolver->getScriptState()->isolate()));
return;
}
@@ -59,13 +57,13 @@ SyncGetRegistrationsCallbacks::SyncGetRegistrationsCallbacks(
SyncGetRegistrationsCallbacks::~SyncGetRegistrationsCallbacks() {}
void SyncGetRegistrationsCallbacks::onSuccess(
- const WebVector<WebSyncRegistration*>& webSyncRegistrations) {
+ const WebVector<mojom::blink::SyncRegistration*>& syncRegistrations) {
if (!m_resolver->getExecutionContext() ||
m_resolver->getExecutionContext()->activeDOMObjectsAreStopped()) {
return;
}
Vector<String> tags;
- for (const WebSyncRegistration* r : webSyncRegistrations) {
+ for (const mojom::blink::SyncRegistration* r : syncRegistrations) {
tags.append(r->tag);
}
m_resolver->resolve(tags);

Powered by Google App Engine
This is Rietveld 408576698