Use FileContentOverlay instead of ContentCache in the new driver.

Use FileContentOverlay instead of ContentCache in the new driver.

We do something strange in Analysis Server and the driver.
We get path, create the corresponding Source, and then put/get the
content using this Source. It seems more natural to use path everywhere.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/5ba0fac0195139fb8a3624f194074980a0d108c1

[Paul Berry, 2016-11-01 19:37:31]

lgtm assuming comment is addressed.

https://codereview.chromium.org/2473473002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/file_state.dart (right):

https://codereview.chromium.org/2473473002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/file_state.dart:44: _map[path] = content;
If content is `null`, we should do `_map.remove(path)` so that we don't leave a
lot of nulls lying around in the map after overlays are removed.

[Brian Wilkerson, 2016-11-01 19:41:54]

Is there a reason to create a new class rather than just change ContentCache? It
would be nice to avoid duplicating implementations. I've been spending a lot of
time lately trying to de-dup code and I'd prefer to not have more such work to
do.

[scheglov, 2016-11-01 19:45:35]

On 2016/11/01 19:41:54, Brian Wilkerson wrote:
> Is there a reason to create a new class rather than just change ContentCache?
It
> would be nice to avoid duplicating implementations. I've been spending a lot
of
> time lately trying to de-dup code and I'd prefer to not have more such work to
> do.

It seems to me like a more intrusive change than I would like.
And we might end up not needing one of the classes.

[scheglov, 2016-11-01 19:46:02]

Description was changed from

==========
Use FileContentOverlay instead of ContentCache in the new driver.

We do something strange in Analysis Server and the driver.
We get path, create the corresponding Source, and then put/get the
content using this Source. It seems more natural to use path everywhere.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Use FileContentOverlay instead of ContentCache in the new driver.

We do something strange in Analysis Server and the driver.
We get path, create the corresponding Source, and then put/get the
content using this Source. It seems more natural to use path everywhere.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/5ba0fac0195139fb8a3624f194074980a0d108c1
==========

[scheglov, 2016-11-01 19:46:03]

Committed patchset #1 (id:1) manually as
5ba0fac0195139fb8a3624f194074980a0d108c1 (presubmit successful).