Don't compute library cycle when the library is resynthesized.

Don't compute library cycle when the library is resynthesized.

As I understand, we infer all types during linking.
So, there is no reason to re-infer types.
And AFAIK ensuring type inference is the only client of library cycle
information.

With the new analysis context we link and have types for all libraries,
including the one we are resolving unit for.

Removing library cycle computation makes analysis almost 40% faster.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/f0a9bb0c9fec17a77dce012abe6d74bd3ff36937

[Brian Wilkerson, 2016-11-02 18:44:48]

lgtm

[Paul Berry, 2016-11-02 20:18:13]

lgtm

[scheglov, 2016-11-02 20:41:08]

Description was changed from

==========
Don't compute library cycle when the library is resynthesized.

As I understand, we infer all types during linking.
So, there is no reason to re-infer types.
And AFAIK ensuring type inference is the only client of library cycle
information.

With the new analysis context we link and have types for all libraries,
including the one we are resolving unit for.

Removing library cycle computation makes analysis almost 40% faster.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Don't compute library cycle when the library is resynthesized.

As I understand, we infer all types during linking.
So, there is no reason to re-infer types.
And AFAIK ensuring type inference is the only client of library cycle
information.

With the new analysis context we link and have types for all libraries,
including the one we are resolving unit for.

Removing library cycle computation makes analysis almost 40% faster.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/f0a9bb0c9fec17a77dce012abe6d74bd3ff36937
==========

[scheglov, 2016-11-02 20:41:09]

Committed patchset #1 (id:1) manually as
f0a9bb0c9fec17a77dce012abe6d74bd3ff36937 (presubmit successful).