Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2473443004: [Offline Pages] Call snapshot controller when OnDomContentLoaded received (Closed)

Created:
4 years, 1 month ago by dougarnett
Modified:
4 years, 1 month ago
Reviewers:
Pete Williamson
CC:
chromium-reviews, cbentzel+watch_chromium.org, dewittj+watch_chromium.org, tburkard+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, gavinp+prer_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Call snapshot controller when OnDomContentLoaded received Looks like we missed putting back PrerenderLoader's call to snapshot controller in patch 2450293002 BUG=659723 Committed: https://crrev.com/29949425c4db0345ee92b384dd403d325df6d63a Cr-Commit-Position: refs/heads/master@{#429469}

Patch Set 1 #

Patch Set 2 : Added flag to control whether DCL reported. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/android/offline_pages/prerendering_loader.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
dougarnett
4 years, 1 month ago (2016-11-02 16:06:00 UTC) #4
dougarnett
Added flag for whether to report DCL to snapshot controller or not to make the ...
4 years, 1 month ago (2016-11-02 19:53:46 UTC) #9
Pete Williamson
lgtm
4 years, 1 month ago (2016-11-02 23:50:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473443004/20001
4 years, 1 month ago (2016-11-03 00:12:54 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-03 00:17:57 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 00:19:41 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/29949425c4db0345ee92b384dd403d325df6d63a
Cr-Commit-Position: refs/heads/master@{#429469}

Powered by Google App Engine
This is Rietveld 408576698