Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2473443003:
Fix an invalid cast from RenderWidgetHostViewGuest to RenderWidgetHostViewMac (Closed)
|
Created:
4 years, 1 month ago by EhsanK Modified:
4 years, 1 month ago Reviewers:
Avi (use Gerrit) CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, mac-reviews_chromium.org, James Su Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix an invalid cast from RenderWidgetHostViewGuest to RenderWidgetHostViewMac
The method GetRenderWidgetHostViewToUse() picks the guest WebContents for the
fullscreen page to be used for start/stopSpeaking commands in Mac. The guest
WebContents's RenderWidgetHostView is however is incorrectly assumed to be
RenderWidgetHostViewMac. It is actually a RenderWidgetHostViewGuest.
Moreover, since the method SpeakSelection() is implemented for
RenderWidgetHostView there is indeed no need to further cast the view to
RenderWidgetHostViewMac/Guest at all.
BUG=661329
Committed: https://crrev.com/b5802c0cf50d70bc72ebc5fae7356af8aa64f98e
Cr-Commit-Position: refs/heads/master@{#429368}
Patch Set 1 #
Messages
Total messages: 20 (14 generated)
Description was changed from ========== Fix an invalid cast from RenderWidgetHostViewGuest to RenderWidgetHostViewMac The method GetRenderWidgetHostViewToUse() picks the guest WebContents for the fullscreen page to be used for start/stopSpeaking commands in Mac. The guest WebContents's RenderWidgetHostView is however is incorrectly assumed to be RenderWidgetHostViewMac. It is actually a RenderWidgetHostViewGuest. Moreover, since the method SpeakSelection() is implemented for RenderWidgetHostView there is indeed no need to further cast the view to RenderWidgetHostViewMac/Guest at all. BUG=661329 ========== to ========== Fix an invalid cast from RenderWidgetHostViewGuest to RenderWidgetHostViewMac The method GetRenderWidgetHostViewToUse() picks the guest WebContents for the fullscreen page to be used for start/stopSpeaking commands in Mac. The guest WebContents's RenderWidgetHostView is however is incorrectly assumed to be RenderWidgetHostViewMac. It is actually a RenderWidgetHostViewGuest. Moreover, since the method SpeakSelection() is implemented for RenderWidgetHostView there is indeed no need to further cast the view to RenderWidgetHostViewMac/Guest at all. ==========
The CQ bit was checked by ekaramad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ekaramad@chromium.org changed reviewers: + avi@chromium.org
Avi, could you please review this change? Thanks!
Description was changed from ========== Fix an invalid cast from RenderWidgetHostViewGuest to RenderWidgetHostViewMac The method GetRenderWidgetHostViewToUse() picks the guest WebContents for the fullscreen page to be used for start/stopSpeaking commands in Mac. The guest WebContents's RenderWidgetHostView is however is incorrectly assumed to be RenderWidgetHostViewMac. It is actually a RenderWidgetHostViewGuest. Moreover, since the method SpeakSelection() is implemented for RenderWidgetHostView there is indeed no need to further cast the view to RenderWidgetHostViewMac/Guest at all. ========== to ========== Fix an invalid cast from RenderWidgetHostViewGuest to RenderWidgetHostViewMac The method GetRenderWidgetHostViewToUse() picks the guest WebContents for the fullscreen page to be used for start/stopSpeaking commands in Mac. The guest WebContents's RenderWidgetHostView is however is incorrectly assumed to be RenderWidgetHostViewMac. It is actually a RenderWidgetHostViewGuest. Moreover, since the method SpeakSelection() is implemented for RenderWidgetHostView there is indeed no need to further cast the view to RenderWidgetHostViewMac/Guest at all. BUG=661329 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Yikes! LGTM.
Thanks avi@!
The CQ bit was checked by ekaramad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ekaramad@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix an invalid cast from RenderWidgetHostViewGuest to RenderWidgetHostViewMac The method GetRenderWidgetHostViewToUse() picks the guest WebContents for the fullscreen page to be used for start/stopSpeaking commands in Mac. The guest WebContents's RenderWidgetHostView is however is incorrectly assumed to be RenderWidgetHostViewMac. It is actually a RenderWidgetHostViewGuest. Moreover, since the method SpeakSelection() is implemented for RenderWidgetHostView there is indeed no need to further cast the view to RenderWidgetHostViewMac/Guest at all. BUG=661329 ========== to ========== Fix an invalid cast from RenderWidgetHostViewGuest to RenderWidgetHostViewMac The method GetRenderWidgetHostViewToUse() picks the guest WebContents for the fullscreen page to be used for start/stopSpeaking commands in Mac. The guest WebContents's RenderWidgetHostView is however is incorrectly assumed to be RenderWidgetHostViewMac. It is actually a RenderWidgetHostViewGuest. Moreover, since the method SpeakSelection() is implemented for RenderWidgetHostView there is indeed no need to further cast the view to RenderWidgetHostViewMac/Guest at all. BUG=661329 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix an invalid cast from RenderWidgetHostViewGuest to RenderWidgetHostViewMac The method GetRenderWidgetHostViewToUse() picks the guest WebContents for the fullscreen page to be used for start/stopSpeaking commands in Mac. The guest WebContents's RenderWidgetHostView is however is incorrectly assumed to be RenderWidgetHostViewMac. It is actually a RenderWidgetHostViewGuest. Moreover, since the method SpeakSelection() is implemented for RenderWidgetHostView there is indeed no need to further cast the view to RenderWidgetHostViewMac/Guest at all. BUG=661329 ========== to ========== Fix an invalid cast from RenderWidgetHostViewGuest to RenderWidgetHostViewMac The method GetRenderWidgetHostViewToUse() picks the guest WebContents for the fullscreen page to be used for start/stopSpeaking commands in Mac. The guest WebContents's RenderWidgetHostView is however is incorrectly assumed to be RenderWidgetHostViewMac. It is actually a RenderWidgetHostViewGuest. Moreover, since the method SpeakSelection() is implemented for RenderWidgetHostView there is indeed no need to further cast the view to RenderWidgetHostViewMac/Guest at all. BUG=661329 Committed: https://crrev.com/b5802c0cf50d70bc72ebc5fae7356af8aa64f98e Cr-Commit-Position: refs/heads/master@{#429368} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b5802c0cf50d70bc72ebc5fae7356af8aa64f98e Cr-Commit-Position: refs/heads/master@{#429368} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
