Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2473443002: Add an initial omnibox to HTML UI content. (Closed)

Created:
4 years, 1 month ago by cjgrant
Modified:
4 years, 1 month ago
Reviewers:
mthiesse, bshe
CC:
chromium-reviews, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an initial omnibox to HTML UI content. - It currently displays only the current URL - It is not interactive - It needs better styling BUG=641508 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/95c8077faabeac737d9c18169d2916647cb2cc65 Cr-Commit-Position: refs/heads/master@{#431311}

Patch Set 1 #

Patch Set 2 : Remove debug logging print. #

Total comments: 7

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -33 lines) Patch
M chrome/browser/resources/vr_shell/vr_shell_ui.css View 2 chunks +64 lines, -0 lines 0 comments Download
M chrome/browser/resources/vr_shell/vr_shell_ui.html View 1 chunk +32 lines, -21 lines 0 comments Download
M chrome/browser/resources/vr_shell/vr_shell_ui.js View 1 8 chunks +65 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
cjgrant
Guys, a follow-on change will shake up the CSS file for all elements, getting rid ...
4 years, 1 month ago (2016-11-01 18:36:17 UTC) #3
bshe
https://codereview.chromium.org/2473443002/diff/20001/chrome/browser/resources/vr_shell/vr_shell_ui.css File chrome/browser/resources/vr_shell/vr_shell_ui.css (right): https://codereview.chromium.org/2473443002/diff/20001/chrome/browser/resources/vr_shell/vr_shell_ui.css#newcode176 chrome/browser/resources/vr_shell/vr_shell_ui.css:176: left: 0; Perhaps use flex box to be i18n ...
4 years, 1 month ago (2016-11-01 22:24:13 UTC) #4
cjgrant
https://codereview.chromium.org/2473443002/diff/20001/chrome/browser/resources/vr_shell/vr_shell_ui.js File chrome/browser/resources/vr_shell/vr_shell_ui.js (right): https://codereview.chromium.org/2473443002/diff/20001/chrome/browser/resources/vr_shell/vr_shell_ui.js#newcode13 chrome/browser/resources/vr_shell/vr_shell_ui.js:13: let scaleFactor = uiStyle.getPropertyValue('--scaleFactor'); On 2016/11/01 22:24:13, bshe wrote: ...
4 years, 1 month ago (2016-11-09 16:33:26 UTC) #5
cjgrant
https://codereview.chromium.org/2473443002/diff/20001/chrome/browser/resources/vr_shell/vr_shell_ui.js File chrome/browser/resources/vr_shell/vr_shell_ui.js (right): https://codereview.chromium.org/2473443002/diff/20001/chrome/browser/resources/vr_shell/vr_shell_ui.js#newcode47 chrome/browser/resources/vr_shell/vr_shell_ui.js:47: let style = window.getComputedStyle(domElement); On 2016/11/09 16:33:26, cjgrant wrote: ...
4 years, 1 month ago (2016-11-09 18:03:34 UTC) #6
bshe
lgtm https://codereview.chromium.org/2473443002/diff/20001/chrome/browser/resources/vr_shell/vr_shell_ui.js File chrome/browser/resources/vr_shell/vr_shell_ui.js (right): https://codereview.chromium.org/2473443002/diff/20001/chrome/browser/resources/vr_shell/vr_shell_ui.js#newcode47 chrome/browser/resources/vr_shell/vr_shell_ui.js:47: let style = window.getComputedStyle(domElement); On 2016/11/09 18:03:34, cjgrant ...
4 years, 1 month ago (2016-11-10 18:06:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473443002/40001
4 years, 1 month ago (2016-11-10 18:15:59 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-10 19:10:08 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 19:40:24 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/95c8077faabeac737d9c18169d2916647cb2cc65
Cr-Commit-Position: refs/heads/master@{#431311}

Powered by Google App Engine
This is Rietveld 408576698