Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Side by Side Diff: src/compiler/mips/code-generator-mips.cc

Issue 2473343002: MIPS[64]: Fix `[builtins]: Uniformly push argument count in TF-generated builtins` (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/compiler/mips64/code-generator-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 #include "src/compilation-info.h" 6 #include "src/compilation-info.h"
7 #include "src/compiler/code-generator-impl.h" 7 #include "src/compiler/code-generator-impl.h"
8 #include "src/compiler/gap-resolver.h" 8 #include "src/compiler/gap-resolver.h"
9 #include "src/compiler/node-matchers.h" 9 #include "src/compiler/node-matchers.h"
10 #include "src/compiler/osr.h" 10 #include "src/compiler/osr.h"
(...skipping 1912 matching lines...) Expand 10 before | Expand all | Expand 10 after
1923 } else if (descriptor->IsJSFunctionCall()) { 1923 } else if (descriptor->IsJSFunctionCall()) {
1924 __ Prologue(this->info()->GeneratePreagedPrologue()); 1924 __ Prologue(this->info()->GeneratePreagedPrologue());
1925 if (descriptor->PushArgumentCount()) { 1925 if (descriptor->PushArgumentCount()) {
1926 __ Push(kJavaScriptCallArgCountRegister); 1926 __ Push(kJavaScriptCallArgCountRegister);
1927 } 1927 }
1928 } else { 1928 } else {
1929 __ StubPrologue(info()->GetOutputStackFrameType()); 1929 __ StubPrologue(info()->GetOutputStackFrameType());
1930 } 1930 }
1931 } 1931 }
1932 1932
1933 int shrink_slots = frame()->GetSpillSlotCount(); 1933 int shrink_slots =
1934 frame()->GetTotalFrameSlotCount() - descriptor->CalculateFixedFrameSize();
1934 1935
1935 if (info()->is_osr()) { 1936 if (info()->is_osr()) {
1936 // TurboFan OSR-compiled functions cannot be entered directly. 1937 // TurboFan OSR-compiled functions cannot be entered directly.
1937 __ Abort(kShouldNotDirectlyEnterOsrFunction); 1938 __ Abort(kShouldNotDirectlyEnterOsrFunction);
1938 1939
1939 // Unoptimized code jumps directly to this entrypoint while the unoptimized 1940 // Unoptimized code jumps directly to this entrypoint while the unoptimized
1940 // frame is still on the stack. Optimized code uses OSR values directly from 1941 // frame is still on the stack. Optimized code uses OSR values directly from
1941 // the unoptimized frame. Thus, all that needs to be done is to allocate the 1942 // the unoptimized frame. Thus, all that needs to be done is to allocate the
1942 // remaining stack slots. 1943 // remaining stack slots.
1943 if (FLAG_code_comments) __ RecordComment("-- OSR entrypoint --"); 1944 if (FLAG_code_comments) __ RecordComment("-- OSR entrypoint --");
(...skipping 323 matching lines...) Expand 10 before | Expand all | Expand 10 after
2267 padding_size -= v8::internal::Assembler::kInstrSize; 2268 padding_size -= v8::internal::Assembler::kInstrSize;
2268 } 2269 }
2269 } 2270 }
2270 } 2271 }
2271 2272
2272 #undef __ 2273 #undef __
2273 2274
2274 } // namespace compiler 2275 } // namespace compiler
2275 } // namespace internal 2276 } // namespace internal
2276 } // namespace v8 2277 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/compiler/mips64/code-generator-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698