Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2473343002: MIPS[64]: Fix `[builtins]: Uniformly push argument count in TF-generated builtins` (Closed)

Created:
4 years, 1 month ago by ivica.bogosavljevic
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer, danno
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS[64]: Fix `[builtins]: Uniformly push argument count in TF-generated builtins` Fix 4447405b179db63748c10d8cb3d139e795195eb3 A typo in the patch caused failures on MIPS64. There were no failures on MIPS32, but I guess the same patch needs to be applied there as well. BUG= Committed: https://crrev.com/7294f110b86fa8dcfef436bcadb9cd960c62ea1a Cr-Commit-Position: refs/heads/master@{#40763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/compiler/mips/code-generator-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ivica.bogosavljevic
PTAL
4 years, 1 month ago (2016-11-04 08:24:40 UTC) #2
danno
lgtm
4 years, 1 month ago (2016-11-04 11:48:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473343002/1
4 years, 1 month ago (2016-11-04 12:29:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 12:49:12 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:22:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7294f110b86fa8dcfef436bcadb9cd960c62ea1a
Cr-Commit-Position: refs/heads/master@{#40763}

Powered by Google App Engine
This is Rietveld 408576698