Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2473313005: Page Info (native Mac): truncate permission labels and add tooltip. (Closed)

Created:
4 years, 1 month ago by lgarron
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Page Info (native Mac): truncate permission labels and add tooltip. BUG=654268 TEST=Try the following on Mac twice, once with Chrome set to German, once with it set to Hebrew (change this in `System Preferences.app` > `Language & Region` > Add to `Preferred languages:` and drag to top). 1) Visit google.com and click on the lock icon in the omnibox to open Page Info 2) Verify that the last permission (MIDI, with a keyboard icon) has a label is truncated using an ellipsis (note: Hebrew is an RTL language, so the ellipsis for it should be on the left) 3) Hover over the label, and check that it shows a full version of the truncated string. Review-Url: https://codereview.chromium.org/2471253003 Cr-Commit-Position: refs/heads/master@{#429665} (cherry picked from commit 4d4e9096b9e299a1d910c2647c6328f30110b0c2) Committed: https://chromium.googlesource.com/chromium/src/+/16886bfae4dff4896be1047f580b19aa2a08e14f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm View 3 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
lgarron
4 years, 1 month ago (2016-11-04 20:54:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
16886bfae4dff4896be1047f580b19aa2a08e14f (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698