Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Unified Diff: chrome/browser/chrome_content_browser_client_browsertest.cc

Issue 24733003: Update defaults for InstantExtended. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Clean up test. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client_browsertest.cc
diff --git a/chrome/browser/chrome_content_browser_client_browsertest.cc b/chrome/browser/chrome_content_browser_client_browsertest.cc
index 3bb56a5209f5c0f5ae9cd1b979fdb1a98327ca77..3dc39befc3566c55a314f2f50dabab8653b79fb9 100644
--- a/chrome/browser/chrome_content_browser_client_browsertest.cc
+++ b/chrome/browser/chrome_content_browser_client_browsertest.cc
@@ -4,7 +4,6 @@
#include "base/command_line.h"
#include "base/metrics/field_trial.h"
-#include "chrome/browser/search/search.h"
#include "chrome/browser/search_engines/template_url_service.h"
#include "chrome/browser/search_engines/template_url_service_factory.h"
#include "chrome/browser/ui/browser.h"
@@ -113,7 +112,6 @@ IN_PROC_BROWSER_TEST_F(InstantNTPURLRewriteTest,
InstallTemplateURLWithNewTabPage(url_rewritten);
ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial("InstantExtended",
"Group1 use_cacheable_ntp:1"));
- chrome::EnableInstantExtendedAPIForTesting();
ui_test_utils::NavigateToURL(browser(), url_original);
NavigationEntry* entry = GetLastCommittedEntry();
@@ -123,25 +121,6 @@ IN_PROC_BROWSER_TEST_F(InstantNTPURLRewriteTest,
EXPECT_EQ(url_original, entry->GetVirtualURL());
}
-IN_PROC_BROWSER_TEST_F(ChromeContentBrowserClientBrowserTest,
- UberURLHandler_InstantExtendedNewTabPageDisabled) {
- // Don't do the kSingleProcess shenanigans here (see the dual test) because
- // otherwise RenderViewImpl crashes in a paranoid fit on startup.
- const GURL url_original("chrome://newtab");
- const GURL url_rewritten("http://example.com/newtab");
- InstallTemplateURLWithNewTabPage(url_rewritten);
- ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial("InstantExtended",
- "Group1 use_cacheable_ntp:1"));
- chrome::DisableInstantExtendedAPIForTesting();
-
- ui_test_utils::NavigateToURL(browser(), url_original);
- NavigationEntry* entry = GetLastCommittedEntry();
-
- ASSERT_TRUE(entry != NULL);
- EXPECT_EQ(url_original, entry->GetURL());
- EXPECT_EQ(url_original, entry->GetVirtualURL());
-}
-
// Test that a basic navigation works in --site-per-process mode. This prevents
// regressions when that mode calls out into the ChromeContentBrowserClient,
// such as http://crbug.com/164223.

Powered by Google App Engine
This is Rietveld 408576698