Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2691)

Unified Diff: chrome/browser/search/search.h

Issue 24733003: Update defaults for InstantExtended. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search/search.h
diff --git a/chrome/browser/search/search.h b/chrome/browser/search/search.h
index 5f2eee5d0ef8a20056c06f7aab508c355607d039..2b3295404bc8de9bb23c92b640839e25af3b4fed 100644
--- a/chrome/browser/search/search.h
+++ b/chrome/browser/search/search.h
@@ -140,10 +140,6 @@ bool ShouldShowInstantNTP();
// field trials.
bool ShouldShowRecentTabsOnNTP();
-// Returns true if Instant Extended should be disabled on the search results
-// page.
-bool ShouldSuppressInstantExtendedOnSRP();
-
// Transforms the input |url| into its "effective URL". The returned URL
// facilitates grouping process-per-site. The |url| is transformed, for
// example, from
@@ -197,26 +193,20 @@ bool ShouldPrefetchSearchResultsOnSRP();
// The following APIs are exposed for use in tests only.
// -----------------------------------------------------
-// Forces the Instant Extended API to be enabled for tests.
-void EnableInstantExtendedAPIForTesting();
-
-// Forces the Instant Extended API to be disabled for tests.
-void DisableInstantExtendedAPIForTesting();
+// Forces query in the omnibox to be enabled for tests.
+void EnableQueryExtractionForTesting();
// Type for a collection of experiment configuration parameters.
typedef std::vector<std::pair<std::string, std::string> > FieldTrialFlags;
-// Finds the active field trial group name and parses out the group number and
-// configuration flags. On success, |flags| will be filled with the field trial
-// flags. |flags| must not be NULL. If not NULL, |group_number| will receive the
-// experiment group number.
-// Returns true iff the active field trial is successfully parsed and not
-// disabled.
+// Finds the active field trial group name and parses out the configuration
+// flags. On success, |flags| will be filled with the field trial flags. |flags|
+// must not be NULL. Returns true iff the active field trial is successfully
+// parsed and not disabled.
// Note that |flags| may be successfully populated in some cases when false is
// returned - in these cases it should not be used.
// Exposed for testing only.
-bool GetFieldTrialInfo(FieldTrialFlags* flags,
- uint64* group_number);
+bool GetFieldTrialInfo(FieldTrialFlags* flags);
// Given a FieldTrialFlags object, returns the string value of the provided
// flag.
@@ -241,10 +231,6 @@ bool GetBoolValueForFlagWithDefault(const std::string& flag,
// Returns the Cacheable New Tab Page URL for the given |profile|.
GURL GetNewTabPageURL(Profile* profile);
-// Let tests reset the gate that prevents metrics from being sent more than
-// once.
-void ResetInstantExtendedOptInStateGateForTest();
-
} // namespace chrome
#endif // CHROME_BROWSER_SEARCH_SEARCH_H_

Powered by Google App Engine
This is Rietveld 408576698