Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4198)

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 24733003: Update defaults for InstantExtended. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix test exclusion. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_browsertest.cc
diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc
index 295dd039e914752534e1adf352284bab5265d986..5a57a10e42b3a1b1cebd775de5e87ecf929122bf 100644
--- a/chrome/browser/ui/browser_browsertest.cc
+++ b/chrome/browser/ui/browser_browsertest.cc
@@ -1011,7 +1011,8 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, CommandCreateAppShortcutInvalid) {
// Urls that should not have shortcuts.
GURL new_tab_url(chrome::kChromeUINewTabURL);
- ui_test_utils::NavigateToURL(browser(), new_tab_url);
+ ui_test_utils::NavigateToURLWithDisposition(
+ browser(), new_tab_url, CURRENT_TAB, ui_test_utils::BROWSER_TEST_NONE);
EXPECT_FALSE(command_updater->IsCommandEnabled(IDC_CREATE_SHORTCUTS));
GURL history_url(chrome::kChromeUIHistoryURL);
@@ -2426,7 +2427,7 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, MAYBE_GetSizeForNewRenderView) {
ASSERT_TRUE(https_test_server.Start());
// Start with NTP.
- ui_test_utils::NavigateToURL(browser(), GURL("chrome://newtab"));
+ ui_test_utils::NavigateToURL(browser(), GURL("chrome-internal://newtab"));
ASSERT_EQ(BookmarkBar::DETACHED, browser()->bookmark_bar_state());
WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
@@ -2483,7 +2484,7 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, MAYBE_GetSizeForNewRenderView) {
// Navigate from NTP to a non-NTP page, resizing WebContentsView while
// navigation entry is pending.
- ui_test_utils::NavigateToURL(browser(), GURL("chrome://newtab"));
+ ui_test_utils::NavigateToURL(browser(), GURL("chrome-internal://newtab"));
gfx::Size wcv_resize_insets(-34, -57);
observer.set_wcv_resize_insets(wcv_resize_insets);
ui_test_utils::NavigateToURL(browser(),

Powered by Google App Engine
This is Rietveld 408576698