| Index: chrome/browser/task_manager/task_manager_browsertest.cc
|
| diff --git a/chrome/browser/task_manager/task_manager_browsertest.cc b/chrome/browser/task_manager/task_manager_browsertest.cc
|
| index 12686b476fc3d1f3a61cbf2f576f57615a7e4c5b..233a3c5ba0f4ca31a4337ed0cbed3f0f6dbfe05b 100644
|
| --- a/chrome/browser/task_manager/task_manager_browsertest.cc
|
| +++ b/chrome/browser/task_manager/task_manager_browsertest.cc
|
| @@ -119,6 +119,12 @@ class TaskManagerBrowserTest : public TaskManagerNoShowBrowserTest {
|
| virtual void SetUpOnMainThread() OVERRIDE {
|
| TaskManagerNoShowBrowserTest::SetUpOnMainThread();
|
| TaskManagerNoShowBrowserTest::ShowTaskManager();
|
| +
|
| + // Wait for the InstantNTP prerendered contents to load.
|
| + content::WindowedNotificationObserver observer(
|
| + content::NOTIFICATION_LOAD_STOP,
|
| + content::NotificationService::AllSources());
|
| + observer.Wait();
|
| }
|
|
|
| private:
|
| @@ -142,7 +148,7 @@ IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, NoticeTabContentsChanges) {
|
| GURL url(ui_test_utils::GetTestUrl(base::FilePath(
|
| base::FilePath::kCurrentDirectory), base::FilePath(kTitle1File)));
|
| AddTabAtIndex(0, url, content::PAGE_TRANSITION_TYPED);
|
| - TaskManagerBrowserTestUtil::WaitForWebResourceChange(2);
|
| + TaskManagerBrowserTestUtil::WaitForWebResourceChange(3);
|
|
|
| // Check that the last entry is a tab contents resource whose title starts
|
| // starts with "Tab:".
|
| @@ -155,7 +161,7 @@ IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, NoticeTabContentsChanges) {
|
| // Close the tab and verify that we notice.
|
| browser()->tab_strip_model()->CloseWebContentsAt(0,
|
| TabStripModel::CLOSE_NONE);
|
| - TaskManagerBrowserTestUtil::WaitForWebResourceChange(1);
|
| + TaskManagerBrowserTestUtil::WaitForWebResourceChange(2);
|
| }
|
|
|
| #if defined(USE_ASH)
|
| @@ -247,13 +253,14 @@ IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, NoticeExtensionTabs) {
|
| .AppendASCII("behllobkkfkfnphdnhnkndlbkcpglgmj")
|
| .AppendASCII("1.0.0.0")));
|
|
|
| - // Browser, Extension background page, and the New Tab Page.
|
| - TaskManagerBrowserTestUtil::WaitForWebResourceChange(2);
|
| + // Browser, Extension background page, and the New Tab Page (visible,
|
| + // prerenderd).
|
| + TaskManagerBrowserTestUtil::WaitForWebResourceChange(3);
|
|
|
| // Open a new tab to an extension URL and make sure we notice that.
|
| GURL url("chrome-extension://behllobkkfkfnphdnhnkndlbkcpglgmj/page.html");
|
| AddTabAtIndex(0, url, content::PAGE_TRANSITION_TYPED);
|
| - TaskManagerBrowserTestUtil::WaitForWebResourceChange(3);
|
| + TaskManagerBrowserTestUtil::WaitForWebResourceChange(4);
|
|
|
| // Check that the third entry (background) is an extension resource whose
|
| // title starts with "Extension:".
|
| @@ -277,7 +284,7 @@ IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, NoticeExtensionTabs) {
|
|
|
| // Unload extension to avoid crash on Windows.
|
| UnloadExtension(last_loaded_extension_id_);
|
| - TaskManagerBrowserTestUtil::WaitForWebResourceChange(1);
|
| + TaskManagerBrowserTestUtil::WaitForWebResourceChange(2);
|
| }
|
|
|
| IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, NoticeAppTabs) {
|
| @@ -289,13 +296,13 @@ IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, NoticeAppTabs) {
|
| const extensions::Extension* extension =
|
| service->GetExtensionById(last_loaded_extension_id_, false);
|
|
|
| - // New Tab Page.
|
| - TaskManagerBrowserTestUtil::WaitForWebResourceChange(1);
|
| + // New Tab Page (visible and prerendered).
|
| + TaskManagerBrowserTestUtil::WaitForWebResourceChange(2);
|
|
|
| // Open a new tab to the app's launch URL and make sure we notice that.
|
| GURL url(extension->GetResourceURL("main.html"));
|
| AddTabAtIndex(0, url, content::PAGE_TRANSITION_TYPED);
|
| - TaskManagerBrowserTestUtil::WaitForWebResourceChange(2);
|
| + TaskManagerBrowserTestUtil::WaitForWebResourceChange(3);
|
|
|
| // Check that the third entry (main.html) is of type extension and has both
|
| // a tab contents and an extension. The title should start with "App:".
|
| @@ -310,7 +317,7 @@ IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, NoticeAppTabs) {
|
|
|
| // Unload extension to avoid crash on Windows.
|
| UnloadExtension(last_loaded_extension_id_);
|
| - TaskManagerBrowserTestUtil::WaitForWebResourceChange(1);
|
| + TaskManagerBrowserTestUtil::WaitForWebResourceChange(2);
|
| }
|
|
|
| IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, NoticeHostedAppTabs) {
|
| @@ -419,10 +426,11 @@ IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, MAYBE_ReloadExtension) {
|
| ASSERT_TRUE(LoadExtension(
|
| test_data_dir_.AppendASCII("common").AppendASCII("background_page")));
|
|
|
| - // Wait until we see the loaded extension in the task manager (the three
|
| - // resources are: the browser process, New Tab Page, and the extension).
|
| + // Wait until we see the loaded extension in the task manager (the four
|
| + // resources are: the browser process, visible and prerendered New Tab Page,
|
| + // and the extension).
|
| LOG(INFO) << "waiting for resource change";
|
| - TaskManagerBrowserTestUtil::WaitForWebResourceChange(2);
|
| + TaskManagerBrowserTestUtil::WaitForWebResourceChange(3);
|
|
|
| EXPECT_TRUE(model()->GetResourceExtension(0) == NULL);
|
| EXPECT_TRUE(model()->GetResourceExtension(1) == NULL);
|
| @@ -436,19 +444,19 @@ IN_PROC_BROWSER_TEST_F(TaskManagerBrowserTest, MAYBE_ReloadExtension) {
|
| // doesn't increase.
|
| LOG(INFO) << "First extension reload";
|
| ReloadExtension(extension->id());
|
| - TaskManagerBrowserTestUtil::WaitForWebResourceChange(2);
|
| + TaskManagerBrowserTestUtil::WaitForWebResourceChange(3);
|
| extension = model()->GetResourceExtension(resource_count);
|
| ASSERT_TRUE(extension != NULL);
|
|
|
| LOG(INFO) << "Second extension reload";
|
| ReloadExtension(extension->id());
|
| - TaskManagerBrowserTestUtil::WaitForWebResourceChange(2);
|
| + TaskManagerBrowserTestUtil::WaitForWebResourceChange(3);
|
| extension = model()->GetResourceExtension(resource_count);
|
| ASSERT_TRUE(extension != NULL);
|
|
|
| LOG(INFO) << "Third extension reload";
|
| ReloadExtension(extension->id());
|
| - TaskManagerBrowserTestUtil::WaitForWebResourceChange(2);
|
| + TaskManagerBrowserTestUtil::WaitForWebResourceChange(3);
|
| }
|
|
|
| // Crashy, http://crbug.com/42301.
|
|
|