Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4879)

Unified Diff: chrome/browser/extensions/lazy_background_page_apitest.cc

Issue 24733003: Update defaults for InstantExtended. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix test exclusion. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/lazy_background_page_apitest.cc
diff --git a/chrome/browser/extensions/lazy_background_page_apitest.cc b/chrome/browser/extensions/lazy_background_page_apitest.cc
index 7bd8ac95fee3b50b65383f24800aede65a6df690..903277103dffd6e9f65685f9a160f97e793611e4 100644
--- a/chrome/browser/extensions/lazy_background_page_apitest.cc
+++ b/chrome/browser/extensions/lazy_background_page_apitest.cc
@@ -285,9 +285,8 @@ IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest, MAYBE_WaitForNTP) {
EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
// The extension should've opened a new tab to an extension page.
- EXPECT_TRUE(chrome::IsNTPURL(
- browser()->tab_strip_model()->GetActiveWebContents()->GetURL(),
- browser()->profile()));
+ EXPECT_EQ(GURL(chrome::kChromeUINewTabURL),
sky 2013/10/07 20:30:59 nit: I believe EXPECT_EQ on the spec of the urls g
samarth 2013/10/11 22:26:04 Done.
+ browser()->tab_strip_model()->GetActiveWebContents()->GetURL());
// Lazy Background Page still exists, because the extension created a new tab
// to an extension page.

Powered by Google App Engine
This is Rietveld 408576698