Enable sending MessagePorts to a different renderer (Chromium side)

Enable sending MessagePorts to a different renderer (Chromium side)

The corresponding Blink side is https://codereview.chromium.org/24739002/

BUG=278336
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229809

[marja, 2013-10-15 11:37:02]

jochen, ptal (I'll add owners if you say it lgty)

[jochen (gone - plz use gerrit), 2013-10-16 00:00:06]

lgtm

https://codereview.chromium.org/24733002/diff/13001/content/renderer/render_v...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/24733002/diff/13001/content/renderer/render_v...
content/renderer/render_view_impl.cc:4306: DCHECK(message_port_ids[i] !=
MSG_ROUTING_NONE);
DCHECK_NE

https://codereview.chromium.org/24733002/diff/13001/content/renderer/render_v...
content/renderer/render_view_impl.cc:5036: DCHECK(params.message_port_ids.size()
== params.new_routing_ids.size());
DCHECK_EQ

[marja, 2013-10-16 08:36:53]

tsepez: Could you review content/common/view_messages.h (it's adding fields to
an existing IPC; the corresponding fields already exist in
MessagePortMsg_Message (since sending MessagePorts via a MessagePort works).
jam: FYI
jochen: Thanks for review!

https://codereview.chromium.org/24733002/diff/13001/content/renderer/render_v...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/24733002/diff/13001/content/renderer/render_v...
content/renderer/render_view_impl.cc:4306: DCHECK(message_port_ids[i] !=
MSG_ROUTING_NONE);
On 2013/10/16 00:00:06, jochen wrote:
> DCHECK_NE

Done.

https://codereview.chromium.org/24733002/diff/13001/content/renderer/render_v...
content/renderer/render_view_impl.cc:5036: DCHECK(params.message_port_ids.size()
== params.new_routing_ids.size());
On 2013/10/16 00:00:06, jochen wrote:
> DCHECK_EQ

Done.

[Tom Sepez, 2013-10-16 17:44:41]

messages lgtm.

[commit-bot: I haz the power, 2013-10-17 09:00:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/24733002/23001

[commit-bot: I haz the power, 2013-10-17 12:27:52]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-18 09:53:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/24733002/55001

[commit-bot: I haz the power, 2013-10-18 13:00:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/24733002/55001

[commit-bot: I haz the power, 2013-10-18 18:12:53]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2013-10-21 07:24:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/24733002/55001

[commit-bot: I haz the power, 2013-10-21 10:45:29]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-10-21 13:49:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/24733002/55001

[commit-bot: I haz the power, 2013-10-21 15:05:54]

Change committed as 229809